Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zenith: patch stale lock file #68720

Closed
wants to merge 1 commit into from
Closed

zenith: patch stale lock file #68720

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jan 10, 2021 •
edited
Loading

Fixes CI failure in #68089.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@carlocab carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 10, 2021
@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle rust Rust use is a significant feature of the PR or issue labels Jan 10, 2021
@carlocab carlocab removed the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 10, 2021
@fxcoudert
Copy link
Member

Even with the new lock file it doesn't build on ARM?

@carlocab
Copy link
Member Author

Unfortunately not. I'll need to dig into this some more.

@carlocab carlocab added do not merge CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. labels Jan 10, 2021
@carlocab carlocab mentioned this pull request Jan 10, 2021
Closed
@carlocab
Copy link
Member Author

Yea, looks like it's still the lock file. Dropping the --locked flag leads to a successful build.

Upstream issue filed: bvaisvil/zenith#92

@carlocab carlocab removed the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 10, 2021
@carlocab carlocab marked this pull request as draft January 11, 2021 19:34
@carlocab carlocab closed this Jan 11, 2021
@carlocab carlocab deleted the zenith-lock branch January 24, 2021 03:16
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 24, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
no ARM bottle Formula has no ARM bottle outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlocab @fxcoudert @BrewTestBot