-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: patch for INTERFACE_LINK_LIBS bug #67615
boost: patch for INTERFACE_LINK_LIBS bug #67615
Conversation
Thanks. Can you also include a comment before the patch about when we can expect it to be removed? |
I added a comment that it can be removed with the next release in b45380c |
I've opened a PR to fix
|
I can't reproduce the
to the start of |
I believe it's a bug in homebrew-test-bot. I noticed in the console log of these failing jobs that just before This didn't fail in #66792, because |
I'll finish the thought here. I looked in the logs of #66792 and noticed the same By contrast, I believe |
I'll file an issue for this |
|
b45380c
to
92701db
Compare
I've rebased and added this workaround in 92701db |
On 11.0
One of Cf. #67474, Homebrew/brew#10127 Update: Tried rebuilding only |
92701db
to
361cd48
Compare
I noticed a reference to |
Tried building The only other dependency with
I've also looked whether we need to recurse further down the dependency tree from there, and it (thankfully) doesn't look like it. |
In boost 1.75.0, the cmake INTERFACE_LINK_LIBRARIESS now include non-boost dependencies like libicudata from the keg-only formula icu4c. This introduces linking errors for software that previously linked successfully in brew against boost 1.74.0 shared libraries (see Homebrew#67427 and boostorg/boost_install#47). This adds a patch to the boost formula that has been merged upstream to limit the expansion of INTERFACE_LINK_LIBRARIES to boost's static libraries, so that the linking errors with shared libraries are resolved.
361cd48
to
0b901a7
Compare
Rebuilding
|
Ok, no idea what happened here, but the CI run shouldn't be taking this long. Will try to restart the tests. |
This makes me worried about my own mariadb-connector-odbc change 30e214e I added the reference to the .tbd file because the project's cmake files expected some physically-present file for that setting (so on Big Sur |
CI is green on the Intel Big Sur runner now. Except that the Catalina runner seems to have gotten stuck somewhere... |
thanks for the help @carlocab! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?In boost 1.75.0, the cmake
INTERFACE_LINK_LIBRARIESS
now include non-boost dependencies likelibicudata
from thekeg-only formula
icu4c
. This introduces linking errors for software that previously linked successfully in brew against boost 1.74.0 shared libraries (see #67427 and boostorg/boost_install#47).This adds a patch to the boost formula that has been merged upstream to limit the expansion of
INTERFACE_LINK_LIBRARIES
to boost's static libraries, so that the linking errors with shared libraries are resolved. I've tested it locally to confirm that it resolves my issues documented in osrf/homebrew-simulation#1235.