Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: uses zlib from macos, install .so files on linux #67474

Closed
wants to merge 2 commits into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Dec 22, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka iMichka added the linux to homebrew-core Migration of linuxbrew-core to homebrew-core label Dec 22, 2020
dawidd6
dawidd6 previously approved these changes Dec 22, 2020
@dawidd6 dawidd6 added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 22, 2020
@iMichka
Copy link
Member Author

iMichka commented Dec 23, 2020

On Big Sur:

2020-12-23T01:26:27.3374580Z /usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -Dgpr_EXPORTS -I/tmp/grpc-20201223-89359-1yzmh3j/include -I/tmp/grpc-20201223-89359-1yzmh3j -I/tmp/grpc-20201223-89359-1yzmh3j/third_party/address_sorting/include -I/tmp/grpc-20201223-89359-1yzmh3j/src/core/ext/upb-generated -I/tmp/grpc-20201223-89359-1yzmh3j/src/core/ext/upbdefs-generated -I/tmp/grpc-20201223-89359-1yzmh3j/third_party/upb -DNDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -fPIC -std=c++17 -o CMakeFiles/gpr.dir/src/core/lib/profiling/basic_timers.cc.o -c /tmp/grpc-20201223-89359-1yzmh3j/src/core/lib/profiling/basic_timers.cc
2020-12-23T01:26:27.3379270Z make[2]: *** No rule to make target /Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework', needed by libgpr.13.0.0.dylib'. Stop.
2020-12-23T01:26:27.3380620Z make[2]: *** Waiting for unfinished jobs....

@carlocab
Copy link
Member

Was able to fix this locally. Rebuilding all the formulae it depends on works. At least one of them has the versioned Big Sur SDK path baked in. You can skip rebuilding openssl; it's not that.

I did try being smarter about which of the dependencies to rebuild, but that didn't work, so I just rebuilt all of them except for openssl.

@carlocab
Copy link
Member

This might be related to Homebrew/brew#10127; not sure. @Bo98

@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 26, 2020
@iMichka
Copy link
Member Author

iMichka commented Dec 26, 2020

Rev-bumping abseil worked.

@carlocab
Copy link
Member

Good to know.

I first tried bumping protobuf since the error log looked related to a zlib dependency, and protobuf was the only one that had linkage with zlib. But then rebuilding grpc lead to a different error complaining about not being able to find the CoreFoundation framework which... looked like all of the dependencies. So I ran out of patience and just rebuilt all of them. 😅

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@iMichka iMichka deleted the grpc branch December 27, 2020 22:43
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linux to homebrew-core Migration of linuxbrew-core to homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants