Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartsim: revision bump for bullet #68877

Closed
wants to merge 2 commits into from

Conversation

scpeters
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The bullet formula switched from single-precision floating point to double precision in #67504, then back to single precision in #68634. The dartsim bottle was not rebuilt in #68634, which is causing some dyld: Symbol not found errors (details in #68623 (comment)). This revision bump should fix the ABI.

It's possible that efl needs to be rebuilt as well, but I have not confirmed, so I am just bumping dartsim for now.

@carlocab
Copy link
Member

FYI, this will cause a merge conflict with #65763

@carlocab
Copy link
Member

make[2]: *** No rule to make target `/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/lib/libm.tbd', needed by `lib/libdart.6.9.5.dylib'.  Stop.

Same problem as #67615.

@scpeters
Copy link
Member Author

FYI, this will cause a merge conflict with #65763

I can defer to #65763 if it will be ready soon, but if not, then I'll let you suggest a timing for merging this, once we resolve the 11.0 sdk issue

@carlocab
Copy link
Member

Let's wait for the current CI run at #65763 to finish and we can assess.

That said, this one is a bit harder to resolve, as pretty much all of the dartsim's dependencies will depend on libm/libSystem.

I guess we can start by looking at all of dartsim's dependencies that have not been rebuilt since Homebrew/brew#10072 was merged.

@scpeters
Copy link
Member Author

Let's wait for the current CI run at #65763 to finish and we can assess.

That said, this one is a bit harder to resolve, as pretty much all of the dartsim's dependencies will depend on libm/libSystem.

I guess we can start by looking at all of dartsim's dependencies that have not been rebuilt since Homebrew/brew#10072 was merged.

I just did a grep on a Big Sur machine and saw a reference to MacOSX11.0.sdk in libccd, so I've added a revision bump to that too (sorry I didn't see you comment to wait). Is there a label we could add to say to wait before merging this?

@carlocab
Copy link
Member

Well, that was quick. I'll keep an eye on the icu4c PR to determine when this one can be merged.

@scpeters
Copy link
Member Author

Well, that was quick. I'll keep an eye on the icu4c PR to determine when this one can be merged.

thanks!

@carlocab
Copy link
Member

Another merge conflict emerged somehow, so no point in waiting on this one any longer.

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab mentioned this pull request Jan 13, 2021
@scpeters scpeters deleted the bump_dartsim_bullet_float branch January 13, 2021 06:28
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants