-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dartsim: revision bump for bullet #68877
Conversation
FYI, this will cause a merge conflict with #65763 |
Same problem as #67615. |
Let's wait for the current CI run at #65763 to finish and we can assess. That said, this one is a bit harder to resolve, as pretty much all of the I guess we can start by looking at all of |
I just did a grep on a Big Sur machine and saw a reference to |
Well, that was quick. I'll keep an eye on the |
thanks! |
Another merge conflict emerged somehow, so no point in waiting on this one any longer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?The
bullet
formula switched from single-precision floating point to double precision in #67504, then back to single precision in #68634. Thedartsim
bottle was not rebuilt in #68634, which is causing somedyld: Symbol not found
errors (details in #68623 (comment)). This revision bump should fix the ABI.It's possible that
efl
needs to be rebuilt as well, but I have not confirmed, so I am just bumpingdartsim
for now.