[Service Bus] Update websocket options shape #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have this PR target the feature/service-bus-track-2 branch? |
ramya-rao-a
reviewed
Feb 11, 2020
| /** | ||
| * Options to configure the channelling of the AMQP connection over Web Sockets. | ||
| */ | ||
| export interface WebSocketOptions { |
There was a problem hiding this comment.
Now that we are duplicating this in Event Hubs and Service Bus, how about moving this interface to @azure/core-amqp?
There was a problem hiding this comment.
good idea, will do.
ramya-rao-a
reviewed
Feb 11, 2020
| @@ -93,9 +110,10 @@ export class ServiceBusClient { | |||
| config = ConnectionConfig.create(hostOrConnectionString); | |||
|
|
|||
| options = credentialOrServiceBusClientOptions as ServiceBusClientOptions; | |||
| config.webSocket = options && options.webSocket; | |||
| config.webSocket = options && options.webSocketOptions?.webSocket; | |||
There was a problem hiding this comment.
options?.webSocketOptions?.webSocket ?
Just opened as a draft, I'll re-open the PR in the central repo against the master branch once Azure#7312 is merged. |
…7211) by extracting then removing them from the url and parse the updated url as URLBuilder doesn't support them.
* Update root README - Making it more accessible to people consuming this page on azure.github.io to avoid redirecting to github from docs - Updating the description to point people to the most recent packages * Update README.md
Even in the case of test timing out the build should be finished under one hour. Shortening the timeout to 60 minutes so we are not wasting build agent resource.
put the latest version to the top
* Pin core-amqp version to preview.1 * Update lock file * Fix merge conflicts * [Service Bus] Update to use core-amqp (Azure#5324) * Use core-amqp in atom management client, comment tests that use token provider * [Service Bus] Update to use latest core-amqp (Azure#6861) * [Service Bus] Update constructors to add overloads and use Azure Identity (Azure#5436) * sync-versions: rhea-promise and @azure/core-amqp for service-bus * resolve merge conflicts appropriately * API Report File for "@azure/service-bus" * Address feedback * SERVICEBUS_CONNECTION_STRING_BROWSER remove from karma.conf * update pnpm-lock file * update API Report File for "@azure/service-bus" * remove rhea and rhea-promise dependencies * add "rhea-promise" back Co-authored-by: Ramya Rao <[email protected]> Co-authored-by: ramya0820 <[email protected]>
HarshaNalluru
force-pushed
the
harshan/sb/issue/7066
branch
from
6f1d4a2 to
7556138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.