Shorten timout for storage live tests to 60 minutes #7292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even in the case of test timing out the build should be finished under one hour. Shortening the timeout to 60 minutes so we are not wasting build agent resource.
jeremymeng
requested review from
danieljurek,
KarishmaGhiya,
mikeharder,
mitchdenny and
weshaggard
as code owners
mikeharder
approved these changes
Feb 12, 2020
weshaggard
reviewed
Feb 18, 2020
| @@ -5,6 +5,7 @@ parameters: | |||
| ResourceServiceDirectory: "" | |||
| EnvVars: {} | |||
| MaxParallel: 0 | |||
| TimeoutInMinutes: 240 | |||
There was a problem hiding this comment.
Do we think we are at a point where we can lower the default for everyone?
There was a problem hiding this comment.
Perhaps invert this and make the default 60 and for any pipelines that need more time they set it in their pipeline?
There was a problem hiding this comment.
Good idea! Do we still want to merge JS pipelines so each service only has one single nightly test pipeline? That might impact the default value we want to use here.
There was a problem hiding this comment.
cc @danieljurek
Yes I do believe it is our goal to have one live test pipeline per service directory instead of per package.
mikeharder
added a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even in the case of test timing out the build should be finished under one hour.
Shortening the timeout to 60 minutes so we are not wasting build agent resource.