[core-http] support username and password in proxy url string #7211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an alternative to PR #7168 |
jeremymeng
added
Azure.Core
Client
xirzec
approved these changes
Feb 3, 2020
by extracting then removing them from the url and parse the updated url as URLBuilder doesn't support them.
jeremymeng
force-pushed
the
proxy-user-pass
branch
from
308fb0a to
fb31f32
Compare
daviwil
approved these changes
Feb 11, 2020
| return { urlWithoutAuth: url}; | ||
| } | ||
|
|
||
| const schemeIndex = url.indexOf("://") |
There was a problem hiding this comment.
I wonder if you could get away with using a regex to simplify the parsing here:
const urlMatch = url.match(/((\w+):\/\/)?((.*):(.*)@)?.*$/);
const username = urlMatch[4];
const password = urlMatch[5];
Not sure if it's more likely to cause trouble than the current approach though, so take it or leave it :)
There was a problem hiding this comment.
I like it! It is more JavaScript-y. Although I also need to remove the auth part from the original url. I'd need another regex to do that?
bterlson
approved these changes
Feb 11, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by extracting then removing them from the url and parse the updated
url as URLBuilder doesn't support them.
For #5011