[Service Bus] Merge feature/service-bus-track-2 into master #7312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto harsha/sb/merge-to-master
HarshaNalluru
changed the title
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Live tests - Build ✔ green |
HarshaNalluru
changed the title
HarshaNalluru
added
Client
HarshaNalluru
requested review from
bterlson,
chradek,
danieljurek and
KarishmaGhiya
as code owners
ramya-rao-a
reviewed
Feb 11, 2020
ramya-rao-a
reviewed
Feb 11, 2020
ramya-rao-a
previously requested changes
Feb 11, 2020
|
@HarshaNalluru After addressing the review comments and resolving the merge conflicts, please trigger the live tests |
…to harshan/sb/merge-to-master
|
/azp run js - servicebus - tests |
|
Pull request contains merge conflicts. |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chradek
reviewed
Feb 11, 2020
| @@ -90,11 +88,12 @@ | |||
| "long": "^4.0.0", | |||
| "process": "^0.11.10", | |||
| "rhea": "^1.0.18", | |||
| "rhea-promise": "^0.1.15", | |||
| "rhea-promise": "^1.0.0", | |||
There was a problem hiding this comment.
This and rhea shouldn't be needed anymore. core-amqp pulls them in.
There was a problem hiding this comment.
removed rhea and rhea-promise.
There was a problem hiding this comment.
Sorry, I didn't realize rhea-promise was being used directly. It looks like only rhea can be safely removed.
There was a problem hiding this comment.
added "rhea-promise" back
|
|
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chradek
approved these changes
Feb 11, 2020
HarshaNalluru
dismissed
ramya-rao-a’s stale review
Dismissing since approved b y Chris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to merge
feature/service-bus-track-2branch intomaster.