Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] [Event Hubs] Add jitter for the delay during send event - RetryConfig #7351

Closed
HarshaNalluru opened this issue Feb 11, 2020 · 3 comments
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus

Comments

@HarshaNalluru
Copy link
Member

Reference - #7312 (comment)

@ramya-rao-a : We had some talks in Event Hubs of re-introducing jitter. That should probably apply here as well right?

@chradek : In event hubs we were talking about adding jitter for load balancing to try and reduce the chance for contention when claiming partitions. I don't remember why it would have gotten removed here though...

@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus labels Feb 11, 2020
@HarshaNalluru HarshaNalluru changed the title [Service Bus] [Event Hubs] Adding jitter for the delay during send event - RetryConfig [Service Bus] [Event Hubs] Add jitter for the delay during send event - RetryConfig Feb 11, 2020
@HarshaNalluru
Copy link
Member Author

We should discuss if we even need this before putting in the efforts to add it - By Richard.

@HarshaNalluru HarshaNalluru added this to the [2020] May milestone Apr 9, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] May, [2020] June Apr 24, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] June, Backlog May 1, 2020
@HarshaNalluru HarshaNalluru modified the milestones: [2020] June, [2020] July Jun 5, 2020
@chradek chradek modified the milestones: [2020] July, Backlog Jun 10, 2020
@ramya-rao-a
Copy link
Contributor

@chradek Is this still applicable? Does our guidelines around retries ask for jitter? If not, lets close this

@chradek
Copy link
Contributor

chradek commented Jul 21, 2021

I don't think this is applicable for sending events. Jitter makes sense for the HTTP-based clients, but in AMQP land we use a persistent connection and have other mechanisms for knowing when the peer is able to receive messages.

@chradek chradek closed this as completed Jul 21, 2021
@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus
Projects
None yet
Development

No branches or pull requests

5 participants