[Service Bus] [Event Hubs] Update websocket options shape #7368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
bterlson,
chradek,
ramya-rao-a and
richardpark-msft
as code owners
HarshaNalluru
added
Client
HarshaNalluru
changed the title
chradek
reviewed
Feb 13, 2020
chradek
approved these changes
Feb 14, 2020
ramya-rao-a
reviewed
Mar 6, 2020
| * @property | ||
| * The WebSocket constructor used to create an AMQP connection over a WebSocket. | ||
| * This option should be provided in the below scenarios: | ||
| * - The TCP port 5671 which is that is used by the AMQP connection to Event Hubs is blocked in your environment. |
There was a problem hiding this comment.
Since this is now in core-amqp, "Event Hubs" should not be mentioned.
Skip it altogether
There was a problem hiding this comment.
Welcome back @ramya-rao-a !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #7066
First draft - HarshaNalluru#26
Moved
WebSocketOptionsfrom eventhubs to core-amqp upon @ramya-rao-a's suggestion to avoid duplication.