[storage] Fix typings support for TypeScript 3.1 #7350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
added
Client
xirzec
requested review from
bterlson,
HarshaNalluru,
jiacfan,
ljian3377 and
vinjiang
as code owners
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-file-share - tests |
|
/azp run js - storage-queue - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No tests, though? 😜 /cc @KarishmaGhiya @mikeharder would be nice to test our libraries with various compiler versions as well, perhaps as part of CI? |
|
Live test failures are due to known existing issues. |
I logged #7352 to track adding tests for storage. Yes it would be great if we have automation to cover this. |
|
@bterlson I can open an issue to track this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since TypeScript 3.7 introduced an incompatible change to their typings files, we have to generate a downlevel version that works with 3.1 -> 3.5.
Fixes #7296