Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test merging spotless changes from main to 2.x #294

Closed
wants to merge 188 commits into from

Conversation

MitchellGale
Copy link

Integ is based off 2.x branch
dev is based off main branch

Yury-Fridlyand and others added 30 commits September 28, 2022 13:59
…nize-workflows (opensearch-project#864)

Reorganize GitHub workflows.

(cherry picked from commit 10e44ee)
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit 5aef2e6)

Co-authored-by: vamsi-amazon <[email protected]>
…en-links (opensearch-project#932)

Fix broken links

(cherry picked from commit 4b50a01)
Signed-off-by: Yury-Fridlyand <[email protected]>
* Bump version to 3.0

Signed-off-by: Peng Huo <[email protected]>
…for sql and workbench (opensearch-project#962)

* Merge pull request opensearch-project#907 from derek-ho/enable-windows-macos

feat: enable ci for windows and macos
(cherry picked from commit 0699baa)
Signed-off-by: Derek Ho <[email protected]>

* always and os==ubuntu

Signed-off-by: Derek Ho <[email protected]>

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit 9944f2e)

Co-authored-by: Chen Dai <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
* Fix precedence by reordering grammar rule

Signed-off-by: Chen Dai <[email protected]>

* Fix precedence in PPL

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
…arch-project#1187)

* Add between grammar and in-memory impl

Signed-off-by: Chen Dai <[email protected]>

* Add comparison test for between

Signed-off-by: Chen Dai <[email protected]>

* Add doctest for between

Signed-off-by: Chen Dai <[email protected]>

* Add not between support

Signed-off-by: Chen Dai <[email protected]>

* Fix doctest failure

Signed-off-by: Chen Dai <[email protected]>

* Refactor to rewrite to basic comparison expression

Signed-off-by: Chen Dai <[email protected]>

* Clean up unused code

Signed-off-by: Chen Dai <[email protected]>

* Prepare to publish PR

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit 6c0af83)

Co-authored-by: Chen Dai <[email protected]>
* Updated UTC TIME Functions for like now FunctionProperties.

Signed-off-by: MitchellGale-BitQuill <[email protected]>

* Finished updates to tests.

Signed-off-by: MitchellGale-BitQuill <[email protected]>

* Removed unused import.

Signed-off-by: MitchellGale-BitQuill <[email protected]>

* Addressed PR comments.

Signed-off-by: MitchellGale-BitQuill <[email protected]>

* Removed extra import.

Signed-off-by: MitchellGale-BitQuill <[email protected]>

* removed `DateTimeFunction` used within class.

Signed-off-by: MitchellGale-BitQuill <[email protected]>

Signed-off-by: MitchellGale-BitQuill <[email protected]>
…pensearch-project#1067)

Change relevance functions that query fields to throw a SemanticCheckException when a field is queried that does not exist.

Signed-off-by: forestmvey <[email protected]>
…earch-project#1171)

* Add table write operator and builder

Signed-off-by: Chen Dai <[email protected]>

* Add UT for all new classes

Signed-off-by: Chen Dai <[email protected]>

* Rename child field

Signed-off-by: Chen Dai <[email protected]>

* Add columns field

Signed-off-by: Chen Dai <[email protected]>

* Update javadoc to prepare PR

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit c494d92)

Co-authored-by: Chen Dai <[email protected]>
* Deprecated Spring IoC and using Guice instead

Signed-off-by: Peng Huo <[email protected]>

* fix checkstyle issue

Signed-off-by: Peng Huo <[email protected]>

* Pass injector to action

Signed-off-by: Peng Huo <[email protected]>

* update

Signed-off-by: Peng Huo <[email protected]>

Signed-off-by: Peng Huo <[email protected]>
* Unquote from subquery alias

Signed-off-by: Chen Dai <[email protected]>

* Add comparison test case

Signed-off-by: Chen Dai <[email protected]>

* Add more comparison test case

Signed-off-by: Chen Dai <[email protected]>

* Update doc to remove limitations

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
…ensearch-project#1191)

* Allow score, type and scalar function name as identifier

Signed-off-by: Chen Dai <[email protected]>

* Revert score and ignore failed IT

Signed-off-by: Chen Dai <[email protected]>

* Add comparison test to address PR comment

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
* Fix truncate() function (#188)

Signed-off-by: Margarit Hakobyan <[email protected]>
Signed-off-by: Margarit Hakobyan <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pensearch-project#1181)

* Allow quoted literals only in `DESCRIBE` and `SHOW` clauses. Tests.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix doctest after rebase.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix doctest after rebase. - Typo fix.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Update syntax section.

Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Max Ksyunz and others added 22 commits June 26, 2023 11:32
…project#1667)

* Update sqlite-jdbc to 3.41.2.2 to address CVE-2023-32697

Signed-off-by: MaxKsyunz <[email protected]>

* Don't check column names on H2 results for correctness tests as described in opensearch-project#1667 (comment).

Signed-off-by: Yury-Fridlyand <[email protected]>

* Address PR review comment.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
…ct#1737)

* Add support for Array and ExprValue Parsing With Inner Hits

Signed-off-by: forestmvey <[email protected]>

* Adding schema validation for IT test, and another UT for nested arrays.

Signed-off-by: forestmvey <[email protected]>

* Making handleAggregationResponse a private function.

Signed-off-by: forestmvey <[email protected]>

---------

Signed-off-by: forestmvey <[email protected]>
…t#1789)

* Add Support for Nested Function in Order By Clause (#280)

* Adding order by clause support for nested function.

Signed-off-by: forestmvey <[email protected]>

* Adding test coverage for nested in ORDER BY clause.

Signed-off-by: forestmvey <[email protected]>

* Added nested function validation to NestedAnalyzer.

Signed-off-by: forestmvey <[email protected]>

---------

Signed-off-by: forestmvey <[email protected]>

* Adding semantic check for missing arguments in function and unit test.

Signed-off-by: forestmvey <[email protected]>

---------

Signed-off-by: forestmvey <[email protected]>
…xt (opensearch-project#1779)

* Fix CI (opensearch-project#1760)

* Fix ML-commons missing dependency.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix `mockito` dependency.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Revert changes in `:opensearch` since it is not needed anymore.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>

* Fix CSV/RAW outputting wrong format (#279)

* Fixed bug where CSV/RAW outputs as JSON rather than plain text

Signed-off-by: Matthew Wells <[email protected]>

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
* Add Support for Field Star in Nested Function.

Signed-off-by: forestmvey <[email protected]>

* Removing toString for NestedAllTupleFields.

Signed-off-by: forestmvey <[email protected]>

* Adding IT test for nested all fields in invalid clause of SQL statement.

Signed-off-by: forestmvey <[email protected]>

* Use utility function for checking is nested in NestedAnalyzer.

Signed-off-by: forestmvey <[email protected]>

* Formatting fixes.

Signed-off-by: forestmvey <[email protected]>

---------

Signed-off-by: forestmvey <[email protected]>
* Initial spark application draft

Signed-off-by: Rupal Mahajan <[email protected]>

* Remove temp table

Signed-off-by: Rupal Mahajan <[email protected]>

* Add license header

Signed-off-by: Rupal Mahajan <[email protected]>

* Add scalastyle-config and update readme

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix datatype for result and schema

Signed-off-by: Rupal Mahajan <[email protected]>

* Add test

Signed-off-by: Rupal Mahajan <[email protected]>

* Simplify code using toJSON.collect.toList

Signed-off-by: Rupal Mahajan <[email protected]>

* Add example in readme

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix triple quotes issue

Signed-off-by: Rupal Mahajan <[email protected]>

* Update method name and description

Signed-off-by: Rupal Mahajan <[email protected]>

* Add applicationId

Signed-off-by: Rupal Mahajan <[email protected]>

---------

Signed-off-by: Rupal Mahajan <[email protected]>
* Create Spark Connector

Signed-off-by: Vamsi Manohar <[email protected]>

* Add spark client and engine

Signed-off-by: Rupal Mahajan <[email protected]>

* Remove vars

Signed-off-by: Rupal Mahajan <[email protected]>

* Spark connector draft

Signed-off-by: Rupal Mahajan <[email protected]>

* nit

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix checkstyle errors

Signed-off-by: Rupal Mahajan <[email protected]>

* nit

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix license header

Signed-off-by: Rupal Mahajan <[email protected]>

* Add spark storage test

Signed-off-by: Rupal Mahajan <[email protected]>

* Update comments

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix checkstyle in comments

Signed-off-by: Rupal Mahajan <[email protected]>

* Update tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Address PR comments

Signed-off-by: Rupal Mahajan <[email protected]>

* Refactor class name

Signed-off-by: Rupal Mahajan <[email protected]>

* Address PR comment

Signed-off-by: Rupal Mahajan <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Co-authored-by: Vamsi Manohar <[email protected]>
…roject#1821)

* Support user-defined and incomplete date formats (#273)

* Check custom formats for characters

Signed-off-by: Guian Gumpac <[email protected]>

* Removed duplicated code

Signed-off-by: Guian Gumpac <[email protected]>

* Reworked checking for exprcoretype

Signed-off-by: Guian Gumpac <[email protected]>

* Changed check for time

Signed-off-by: Guian Gumpac <[email protected]>

* Rework processing custom and incomplete formats and add tests.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Values of incomplete and incorrect formats to be returned as `TIMESTAMP` instead of `STRING`.

Signed-off-by: Yury-Fridlyand <[email protected]>

* Complete fix and update tests.

Signed-off-by: Yury-Fridlyand <[email protected]>

* More fixes for god of fixes.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>

* Refactoring.

Signed-off-by: Yury-Fridlyand <[email protected]>

---------

Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Guian Gumpac <[email protected]>
* Add _routing to SQL includes list

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update IT index

Signed-off-by: Andrew Carbonetto <[email protected]>

* Update doctest

Signed-off-by: acarbonetto <[email protected]>

* Add WHERE clause IT tests

Signed-off-by: acarbonetto <[email protected]>

* Fix IT test

Signed-off-by: acarbonetto <[email protected]>

* Update documentation for _routing

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: acarbonetto <[email protected]>
)

* Added new datetime functions and aliases to PPL (#281)

* Added new functions, and alias' to PPL

Signed-off-by: Matthew Wells <[email protected]>

* removed message about functions not working with dates with 0 month/day as those dates don't exist

Signed-off-by: Matthew Wells <[email protected]>

* changed documentation to be in alphabetical order

Signed-off-by: Matthew Wells <[email protected]>

---------

Signed-off-by: Matthew Wells <[email protected]>
* Update docs.



* Apply suggestions from code review





* Add example of quote escaping.



* Update docs/user/general/datatypes.rst





* Update docs/user/general/datatypes.rst





---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Forest Vey <[email protected]>
Co-authored-by: Matthew Wells <[email protected]>
* Create Spark Connector

Signed-off-by: Vamsi Manohar <[email protected]>

* Add spark client and engine

Signed-off-by: Rupal Mahajan <[email protected]>

* Remove vars

Signed-off-by: Rupal Mahajan <[email protected]>

* Spark connector draft

Signed-off-by: Rupal Mahajan <[email protected]>

* nit

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix checkstyle errors

Signed-off-by: Rupal Mahajan <[email protected]>

* nit

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix license header

Signed-off-by: Rupal Mahajan <[email protected]>

* Add spark storage test

Signed-off-by: Rupal Mahajan <[email protected]>

* Update comments

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix checkstyle in comments

Signed-off-by: Rupal Mahajan <[email protected]>

* Update tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Add emr client

Signed-off-by: Rupal Mahajan <[email protected]>

* Set default values for flint args

Signed-off-by: Rupal Mahajan <[email protected]>

* Validate emr auth type

Signed-off-by: Rupal Mahajan <[email protected]>

* Add default constants for flint

Signed-off-by: Rupal Mahajan <[email protected]>

* Update unit tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Address PR comments

Signed-off-by: Rupal Mahajan <[email protected]>

* tests draft

Signed-off-by: Rupal Mahajan <[email protected]>

* Refactor class name

Signed-off-by: Rupal Mahajan <[email protected]>

* Rename classes and update tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Update scan operator test

Signed-off-by: Rupal Mahajan <[email protected]>

* Address PR comment

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix Connection pool shut down issue

Signed-off-by: Rupal Mahajan <[email protected]>

* Update emr unit tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Update doc and tests

Signed-off-by: Rupal Mahajan <[email protected]>

* nit

Signed-off-by: Rupal Mahajan <[email protected]>

* Update EMR clinet impl tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Address PR comments

Signed-off-by: Rupal Mahajan <[email protected]>

* Make spark & flint jars configurable

Signed-off-by: Rupal Mahajan <[email protected]>

* Address comments

Signed-off-by: Rupal Mahajan <[email protected]>

* Add spark application id in logs

Signed-off-by: Rupal Mahajan <[email protected]>

* nit

Signed-off-by: Rupal Mahajan <[email protected]>

* Delete result when not required

Signed-off-by: Rupal Mahajan <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Co-authored-by: Vamsi Manohar <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Comment on lines +25 to +36
"%\\{"
+ "(?<name>"
+ "(?<pattern>[A-z0-9]+)"
+ "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?"
+ ")"
+ "(?:=(?<definition>"
+ "(?:"
+ "(?:[^{}]+|\\.+)+"
+ ")+"
+ ")"
+ ")?"
+ "\\}");

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '%{{0=' and containing many repetitions of 'z'.
Comment on lines +25 to +36
"%\\{"
+ "(?<name>"
+ "(?<pattern>[A-z0-9]+)"
+ "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?"
+ ")"
+ "(?:=(?<definition>"
+ "(?:"
+ "(?:[^{}]+|\\.+)+"
+ ")+"
+ ")"
+ ")?"
+ "\\}");

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '%{{0=' and containing many repetitions of '.'.
Comment on lines +25 to +36
"%\\{"
+ "(?<name>"
+ "(?<pattern>[A-z0-9]+)"
+ "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?"
+ ")"
+ "(?:=(?<definition>"
+ "(?:"
+ "(?:[^{}]+|\\.+)+"
+ ")+"
+ ")"
+ ")?"
+ "\\}");

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
Comment on lines +25 to +36
"%\\{"
+ "(?<name>"
+ "(?<pattern>[A-z0-9]+)"
+ "(?::(?<subname>[A-z0-9_:;,\\-\\/\\s\\.']+))?"
+ ")"
+ "(?:=(?<definition>"
+ "(?:"
+ "(?:[^{}]+|\\.+)+"
+ ")+"
+ ")"
+ ")?"
+ "\\}");

Check warning

Code scanning / CodeQL

Overly permissive regular expression range

Suspicious character range that is equivalent to \[A-Z\\[\\\\]^_`a-z\].
andy-k-improving pushed a commit that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.