[Backport main] #907 - enable windows and macos CI for sql and workbench #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-macos feat: enable ci for windows and macos (cherry picked from commit 0699baa) Signed-off-by: Derek Ho <[email protected]>
derek-ho
commented
Oct 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #962 +/- ##
=============================================
- Coverage 94.83% 62.76% -32.07%
=============================================
Files 291 10 -281
Lines 7795 658 -7137
Branches 568 119 -449
=============================================
- Hits 7392 413 -6979
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Derek Ho <[email protected]>
anirudha
approved these changes
Oct 25, 2022
Yury-Fridlyand
approved these changes
Oct 25, 2022
ps48
reviewed
Oct 25, 2022
| @@ -20,25 +20,32 @@ on: | |||
| jobs: | |||
| build: | |||
| strategy: | |||
| # Run all jobs | |||
| fail-fast: false | |||
There was a problem hiding this comment.
Why was fail fast was disabled here?
There was a problem hiding this comment.
This was mainly for my local dev to run all CI even if one fails. I think it would be useful for future devs to figure out if something is breaking just because of OS, java-version, etc. by running all combinations by default.
joshuali925
approved these changes
Oct 25, 2022
YANG-DB
approved these changes
Oct 25, 2022
derek-ho
changed the title
derek-ho
changed the title
derek-ho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: enable ci for windows and macos
(cherry picked from commit 0699baa)
Signed-off-by: Derek Ho [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.