Fix CI

[Yury-Fridlyand]

Description

In opensearch-project/OpenSearch#8035 some classes were moved from core to common-utils without renaming or changing hierarchy. In ml-commons in opensearch-project/ml-commons#993 a new dependency was added to keep things up to date, but the same dependency should be added in SQL plugin as well.
This fix adds:

1. common-utils dependency to :opensearch
2. updates mockito version in plugin (:opensearch-sql-plugin) to avoid conflicts between 5.2.0 and 5.4.0 versions. 5.4.0 comes from upstream.

Execution failed for task ':opensearch-sql-plugin:compileTestJava'.
> Could not resolve all dependencies for configuration ':opensearch-sql-plugin:testCompileClasspath'.
   > Conflict(s) found for the following module(s):
       - org.mockito:mockito-core between versions 5.4.0 and 5.2.0
     Run with:
         --scan or
         :opensearch-sql-plugin:dependencyInsight --configuration testCompileClasspath --dependency org.mockito:mockito-core
     to get more insight on how to solve the conflict.

Issues Resolved

#1753

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Merging #1760 (66b98fd) into main (bb020ac) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1760   +/-   ##
=========================================
  Coverage     97.29%   97.29%           
  Complexity     4408     4408           
=========================================
  Files           388      388           
  Lines         10944    10944           
  Branches        774      774           
=========================================
  Hits          10648    10648           
  Misses          289      289           
  Partials          7        7           

Flag	Coverage Δ
sql-engine	97.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[vmmusings]

Did this fix the NoClassDef error?
Or it automatically got fixed after the latest changes got pushed to sonatype snaphot repo. https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/

[Yury-Fridlyand]

I just restarted CI on main it failed: https://github.com/opensearch-project/sql/actions/runs/5320847765/jobs/9655483529. So fix is still required.

[penghuo]

Re-run the CI, only see the following errors. Does common-utils necessary?

Execution failed for task ':opensearch-sql-plugin:compileTestJava'.
AstExpressionBuilderTest > canBuildArithmeticExpressionPrecedence() PASSED
> Could not resolve all dependencies for configuration ':opensearch-sql-plugin:testCompileClasspath'.

   > Conflict(s) found for the following module(s):
AstExpressionBuilderTest > canBuildComparisonExpression() PASSED
       - org.mockito:mockito-core between versions 5.4.0 and 5.2.0
     Run with:
         --scan or
         :opensearch-sql-plugin:dependencyInsight --configuration testCompileClasspath --dependency org.mockito:mockito-core
     to get more insight on how to solve the conflict.

[Yury-Fridlyand]

Right, perhaps snapshots was updated which makes this dependency unneeded. Reverted in 66b98fd.
Thank you for testing!

[vmmusings]

common-utils

Nothing got moved to common-utils. By common-utilsare you referring to this https://github.com/opensearch-project/common-utils?
I am trying to understand the root cause of the CI issue and how did the current PR changes fixed.

[acarbonetto]

Adding more dependencies makes me not happy, but I suppose it's for a good cause (breaking up the monolithic core library).

[penghuo]

Thanks for the change!