Manually Backporting 1779 to 2.x #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt (opensearch-project#1779) * Fix CI (opensearch-project#1760) * Fix ML-commons missing dependency. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix `mockito` dependency. Signed-off-by: Yury-Fridlyand <[email protected]> * Revert changes in `:opensearch` since it is not needed anymore. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Matthew Wells <[email protected]> * Fix CSV/RAW outputting wrong format (#279) * Fixed bug where CSV/RAW outputs as JSON rather than plain text Signed-off-by: Matthew Wells <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Matthew Wells <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 1ec696d)
Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
matthewryanwells
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
GumpacG
reviewed
Jun 28, 2023
integ-test/src/test/java/org/opensearch/sql/sql/CsvFormatIT.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 2.x #1796 +/- ##
============================================
+ Coverage 97.34% 97.35% +0.01%
- Complexity 4409 4443 +34
============================================
Files 388 388
Lines 10940 10996 +56
Branches 773 784 +11
============================================
+ Hits 10649 10705 +56
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Matthew Wells <[email protected]>
Yury-Fridlyand
approved these changes
Jun 28, 2023
acarbonetto
approved these changes
Jun 28, 2023
forestmvey
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually backporting #1779 into 2.x as a few of the IT tests failed due to a small difference in the
getContentTypemethodIssues Resolved
Automatic backport to 2.x failing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.