Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flakytest when tests.locale=tr #1827

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Jul 10, 2023

Description

  • Fix flaktest found in IT when -Dtests.locale=tr.
  • Failed IT.
./gradlew ':integ-test:integTest' --tests "org.opensearch.sql.ppl.StandaloneIT.testSourceFieldQuery" -Dtests.seed=8DBF6CCDC4AAC1CC -Dtests.security.manager=false -Dtests.locale=tr -Dtests.timezone=Pacific/Marquesas -Druntime.java=11

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1827 (837d3ab) into main (f38ffed) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1827   +/-   ##
=========================================
  Coverage     97.33%   97.33%           
  Complexity     4490     4490           
=========================================
  Files           394      394           
  Lines         11119    11119           
  Branches        795      795           
=========================================
  Hits          10823    10823           
  Misses          289      289           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opensearch/sql/protocol/response/QueryResult.java 100.00% <100.00%> (ø)

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it fix #1590 and #1275? Can you add IT or UT?

@Yury-Fridlyand
Copy link
Collaborator

Reminder: backport to 2.x when CI issues resolved on 2.x branch.

@MaxKsyunz MaxKsyunz merged commit 4178c03 into opensearch-project:main Jul 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit 4178c03)
penghuo added a commit that referenced this pull request Jul 11, 2023
Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit 4178c03)

Co-authored-by: Peng Huo <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit 4178c03)
penghuo added a commit that referenced this pull request Jul 11, 2023
Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit 4178c03)

Co-authored-by: Peng Huo <[email protected]>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 11, 2023
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 11, 2023
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants