-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 3.0 #831
Bump version to 3.0 #831
Conversation
Signed-off-by: Peng Huo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #831 +/- ##
=========================================
Coverage 94.83% 94.83%
Complexity 2916 2916
=========================================
Files 291 291
Lines 7795 7795
Branches 568 568
=========================================
Hits 7392 7392
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Peng Huo <[email protected]>
34a420f
IT failed |
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
0.6); | ||
Assert | ||
.assertEquals(39.0, getDoubleAggregationValue(result, "PERCENTILES(age)", "values", "95.0"), | ||
0.001); | ||
0.6); | ||
Assert | ||
.assertEquals(40.0, getDoubleAggregationValue(result, "PERCENTILES(age)", "values", "99.0"), | ||
0.001); | ||
0.6); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these tests failed? What was changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Percentiles are (usually) approximate. I did not dive deep into the core change yet. I am sure it is not becuase of query engine.
opensearch-build PR. add SQL 2.4. opensearch-project/opensearch-build#2684 |
@penghuo Do you know why Gradle on macOS wasn't finding I wasn't able to build the |
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Test failed because of breaking change in OpenSearch
|
Signed-off-by: Peng Huo <[email protected]>
6f33801
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo [email protected]
Issues Resolved
opensearch-project/opensearch-plugins#142
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.