Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.0 #831

Merged
merged 14 commits into from
Oct 20, 2022
Merged

Bump version to 3.0 #831

merged 14 commits into from
Oct 20, 2022

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Sep 14, 2022

Signed-off-by: Peng Huo [email protected]

Issues Resolved

opensearch-project/opensearch-plugins#142

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <[email protected]>
@penghuo penghuo requested a review from a team as a code owner September 14, 2022 18:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #831 (243bd9e) into main (e733e7b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #831   +/-   ##
=========================================
  Coverage     94.83%   94.83%           
  Complexity     2916     2916           
=========================================
  Files           291      291           
  Lines          7795     7795           
  Branches        568      568           
=========================================
  Hits           7392     7392           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dai-chen
dai-chen previously approved these changes Sep 14, 2022
joshuali925
joshuali925 previously approved these changes Sep 14, 2022
MaxKsyunz
MaxKsyunz previously approved these changes Sep 14, 2022
Signed-off-by: Peng Huo <[email protected]>
@penghuo penghuo dismissed stale reviews from MaxKsyunz, joshuali925, and dai-chen via 34a420f September 14, 2022 20:23
@penghuo
Copy link
Collaborator Author

penghuo commented Sep 14, 2022

IT failed

@MaxKsyunz MaxKsyunz self-assigned this Sep 29, 2022
@penghuo penghuo assigned penghuo and unassigned MaxKsyunz Sep 30, 2022
Comment on lines +169 to +175
0.6);
Assert
.assertEquals(39.0, getDoubleAggregationValue(result, "PERCENTILES(age)", "values", "95.0"),
0.001);
0.6);
Assert
.assertEquals(40.0, getDoubleAggregationValue(result, "PERCENTILES(age)", "values", "99.0"),
0.001);
0.6);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these tests failed? What was changed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Percentiles are (usually) approximate. I did not dive deep into the core change yet. I am sure it is not becuase of query engine.

@penghuo
Copy link
Collaborator Author

penghuo commented Oct 10, 2022

opensearch-build PR. add SQL 2.4. opensearch-project/opensearch-build#2684

anirudha
anirudha previously approved these changes Oct 10, 2022
@MaxKsyunz
Copy link
Collaborator

@penghuo Do you know why Gradle on macOS wasn't finding opensearch.pluginzip plugin on sonotype?

I wasn't able to build the bump/3.0 branch until I built OpenSearch locally and published artifacts to Maven local.
Gradle was failing to find opensearch.pluginzip plugin.

Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
joshuali925
joshuali925 previously approved these changes Oct 13, 2022
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Oct 13, 2022
@penghuo
Copy link
Collaborator Author

penghuo commented Oct 20, 2022

Test failed because of breaking change in OpenSearch

java.lang.AssertionError: aliases version should be present for indices

Signed-off-by: Peng Huo <[email protected]>
@penghuo penghuo dismissed stale reviews from Yury-Fridlyand and joshuali925 via 6f33801 October 20, 2022 16:12
Signed-off-by: Peng Huo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants