Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #911

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Oct 13, 2022

Signed-off-by: Yury-Fridlyand [email protected]

Description

Fix broken links.

Issues Resolved

Link checker GHA failed: https://github.com/Bit-Quill/opensearch-project-sql/actions/runs/3239220029/jobs/5308341724

## Errors per input
### Errors in release-notes/opendistro-for-elasticsearch-sql.release-notes-1.3.0.0.md
* [https://github.com/opendistro-for-elasticsearch/sql/issues215](https://github.com/opendistro-for-elasticsearch/sql/issues215): Failed: Network error (status code: 404)

### Errors in release-notes/opensearch-sql.release-notes-1.2.0.0.md
* [https://github.com/kylepbi%E2%80%A6](https://github.com/kylepbi%E2%80%A6): Failed: Network error (status code: 404)

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Copy link
Collaborator Author

Yury-Fridlyand commented Oct 13, 2022

Any ideas why it wasn't detected before? Should we fix something in the checker?

@codecov-commenter

This comment was marked as spam.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Do you happen to know why it starts failing recently? Issue 215 and its PR is very old.

@Yury-Fridlyand Yury-Fridlyand merged commit 4b50a01 into opensearch-project:2.x Oct 18, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the fix-old-broken-links branch October 18, 2022 17:11
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-911-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4b50a014c6f5701f3061ad950073895b39f68a67
# Push it to GitHub
git push --set-upstream origin backport/backport-911-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-911-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-911-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4b50a014c6f5701f3061ad950073895b39f68a67
# Push it to GitHub
git push --set-upstream origin backport/backport-911-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-911-to-main.

Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 19, 2022
…en-links

Fix broken links

(cherry picked from commit 4b50a01)
Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 19, 2022
…en-links

Fix broken links

(cherry picked from commit 4b50a01)
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 19, 2022
…en-links

Fix broken links

(cherry picked from commit 4b50a01)
Signed-off-by: Yury-Fridlyand <[email protected]>
dai-chen pushed a commit that referenced this pull request Oct 19, 2022
Fix broken links

(cherry picked from commit 4b50a01)
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand added a commit that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants