Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social: update Facebook's color code #13681

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Social: update Facebook's color code #13681

merged 1 commit into from
Oct 10, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Oct 7, 2019

Changes proposed in this Pull Request:

Facebook's Logo now uses a different shade of blue, as per the brand guidelines:
https://en.facebookbrand.com/assets/f-logo/

Before

screenshot 2019-10-07 at 11 21 37

After

screenshot 2019-10-07 at 11 21 02

Testing instructions:

  • Add a Facebook Sharing button to your posts, and pick the "Logo" button style.
  • Enjoy the new blue!

Proposed changelog entry for your changes:

  • Social Networks: update Facebook logo to match new color.

@jeherve
Social: update Facebook's color code
31663d7 
Facebook's Logo now uses a different shade of blue, as per the brand guidelines:
https://en.facebookbrand.com/assets/f-logo/
@jeherve jeherve added [Feature] Sharing Post sharing, sharing buttons [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! Admin Page React-powered dashboard under the Jetpack menu [Type] Janitorial [Pri] Low [Feature] Calypsoify labels Oct 7, 2019
@jeherve jeherve added this to the 7.9 milestone Oct 7, 2019
@jeherve jeherve requested a review from a team October 7, 2019 09:38
@jeherve jeherve self-assigned this Oct 7, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33647-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 31663d7

keoshi
keoshi approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for updating this!

@keoshi keoshi added [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! labels Oct 7, 2019
@kraftbj
Copy link
Contributor

kraftbj commented Oct 10, 2019

The color change is fine, but we need to update the actual logo too. Their guidelines have a white f with no square around it. It looks like the upstream logos repo has it fixed, but we haven't kept up with it ( Automattic/social-logos#94 ).

I'll approve this for the color change so we can be in the spirit of updating it for 7.9 and open a new issue for better tracking social-logos.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 10, 2019
@jeherve
Copy link
Member Author

jeherve commented Oct 10, 2019

Oh, good catch, I didn't think of that. I'll address that in another PR.

@jeherve jeherve merged commit 5393a1d into master Oct 10, 2019
@jeherve jeherve deleted the update/facebook-colors branch October 10, 2019 14:56
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 10, 2019
@kraftbj kraftbj mentioned this pull request Oct 10, 2019
Open
jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
Changelog: add #13681
9efeb89
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
jeherve added a commit to Automattic/wp-calypso that referenced this pull request Oct 16, 2023
@jeherve
Facebook: update color code
4d4b6f4 
Facebook's color code was updated a few years ago. Let's update its color here too.

References:

- Automattic/jetpack#13681
@jeherve jeherve mentioned this pull request Oct 16, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keoshi keoshi keoshi approved these changes

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Calypsoify [Feature] Sharing Post sharing, sharing buttons [Pri] Low [Status] Design Review Complete Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @matticbot @jetpackbot @kraftbj @keoshi