Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Do not show jetpack link when jetpack is not connected to non admin. #13601

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Fix: Do not show jetpack link when jetpack is not connected to non admin. #13601

merged 3 commits into from
Oct 1, 2019

Conversation

enejb
Copy link
Member

@enejb enejb commented Sep 30, 2019

Currently as a non admin. I see the following the Jetpack is not connected and I am not in dev mode. (https://jetpack.com/support/development-mode/)

Screen Shot 2019-09-30 at 3 04 37 PM

This is not ideal. Since there is nothing for the user to do.
This PR removed the link complete for user that do not have mange options privileged. (non admins)

Changes proposed in this Pull Request:

  • Remove the ability for non admins to visit the Jetpack dashboard page when jetpack is not connected.

Testing instructions:

  • Notice that as an non admin user you can't go to the Jetpack dashboard.
    *Notice that as an admin user you can go to the Jetpack dashboard in order to connect jetpack.

Applied the JETPACK_DEV_DEBUG constant in the wp-config.php ( define( 'JETPACK_DEV_DEBUG', true ); )

  • Notice that as an non admin user you can't go to the jetpack dashboard.
  • Notice as an admin that you can go to the jetpack dashboard.

Notice if you connect jetpack.

  • Notice that as an non admin user you can go to the jetpack dashboard.
  • Notice as an admin that you can go to the jetpack dashboard.

Proposed changelog entry for your changes:

  • Removes the jetpack dashboard access for non admin user when Jetpack is not connected.

@enejb enejb added [Type] Bug When a feature is broken and / or not performing as intended General [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 30, 2019
@enejb enejb added this to the 7.9 milestone Sep 30, 2019
@enejb enejb requested review from a team September 30, 2019 14:20
@enejb enejb self-assigned this Sep 30, 2019
@jetpackbot
Copy link

jetpackbot commented Sep 30, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 0160340

tyxla
tyxla previously approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, nice fix! LGTM 🚢

_inc/lib/admin-pages/class.jetpack-react-page.php Outdated Show resolved Hide resolved
@tyxla tyxla added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 1, 2019
@kraftbj kraftbj dismissed stale reviews from tyxla via c8d9856 October 1, 2019 17:17
kraftbj
kraftbj previously approved these changes Oct 1, 2019
View reviewed changes
tyxla
tyxla approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@tyxla tyxla merged commit c99fff0 into master Oct 1, 2019
@tyxla tyxla deleted the update/remove-jp-dashboard-for-not-connecte-users branch October 1, 2019 18:47
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 1, 2019
jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
Changelog: add #13601
e60f86b
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@kraftbj kraftbj kraftbj left review comments

Assignees

@enejb enejb

Labels
General [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
6 participants
@enejb @jetpackbot @kraftbj @tyxla @jeherve @matticbot