Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Related Posts: add Posts to all post types that support them #13805

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Related Posts: add Posts to all post types that support them #13805

merged 1 commit into from
Oct 28, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Oct 22, 2019 •
edited
Loading

Fixes #10203

Changes proposed in this Pull Request:

  • This can be used by folks using the core REST API post endpoint to fetch related posts, instead of the WordPress.com REST API.

Testing instructions:

  • Test this on a site where you've enabled Jetpack's Portfolio custom post type, as well as Related Posts.
  • You should see the Related Posts field when you look at a portfolio item via the core REST API, e.g. https://yoursite.com/wp-json/wp/v2/jetpack-portfolio/35762

Proposed changelog entry for your changes:

  • Related Posts: add Posts to the REST API response for all post types that support them

@jeherve
Related Posts: add Posts to all post types that support them
37c234c 
This can be used by folks using the core REST API post endpoint to fetch related posts, instead of the WordPress.com REST API.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Related Posts [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Low labels Oct 22, 2019
@jeherve jeherve added this to the 7.9 milestone Oct 22, 2019
@jeherve jeherve requested a review from a team October 22, 2019 19:03
@jeherve jeherve self-assigned this Oct 22, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D34337-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 37c234c

@bikedorkjon
Copy link

This was brought up in 2440422-zen

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Oct 22, 2019
ChaosExAnima
ChaosExAnima approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@ChaosExAnima ChaosExAnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks okay here: https://cld.wthms.co/LtdAWF

@htdat
Copy link
Member

htdat commented Oct 23, 2019

I think this would fix the issue here:

@ChaosExAnima ChaosExAnima added [Status] Needs Testing We need to add this change to the testing call for this month's release [Tests] Needs Tests Some Unit Tests would be really useful to include with this PR. and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Testing We need to add this change to the testing call for this month's release labels Oct 23, 2019
@jeherve jeherve merged commit 975677f into master Oct 28, 2019
@jeherve jeherve deleted the update/related-posts-api-types branch October 28, 2019 17:17
@jeherve jeherve removed the [Tests] Needs Tests Some Unit Tests would be really useful to include with this PR. label Oct 28, 2019
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
Changelog: add #13805
3b25ee3
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaosExAnima ChaosExAnima ChaosExAnima approved these changes

Assignees

@jeherve jeherve

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Related Posts [Pri] Low Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.

Related Posts: Add the jetpack-related-posts field to WP REST API for any post type
6 participants
@jeherve @matticbot @jetpackbot @bikedorkjon @htdat @ChaosExAnima