Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook Page Plugin: update deprecated stream attribute #13725

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Facebook Page Plugin: update deprecated stream attribute #13725

merged 2 commits into from
Oct 25, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Oct 11, 2019 •
edited
Loading

Fixes #13717

Changes proposed in this Pull Request:

  • This attribute has now been deprecated by Facebook:

The attribute data-show-posts is deprecated. Please use the attribute tabs/data-tabs and use the value timeline to show posts from the Page's timeline.
-- https://developers.facebook.com/docs/plugins/page-plugin/

This updates to the new recommended attribute.

Note

I did not update the label from "Show Stream" to "Show Timeline". Maybe we should? I'm not sure which term is more understandable for site owners.
I changed the UI to use the word "Timeline" as per Michelle's recommendation below:

image

Testing instructions:

  • Go to Jetpack > Settings > Writing and enable the extra sidebar widgets
  • Go to Appearance > Customize
  • Add a new Facebook Widget to your site.
  • In the widget options, choose to display a stream of posts.
  • Check your site, the widget should show a list of recent posts from the Page.

Proposed changelog entry for your changes:

  • Facebook Page Plugin: update deprecated option in the widget.

@jeherve
Facebook Page Plugin: update deprecated stream attribute
b2519a8 
Fixes #13717

This attribute has now been deprecated by Facebook:
> The attribute data-show-posts is deprecated. Please use the attribute tabs/data-tabs and use the value timeline to show posts from the Page's timeline.
-- https://developers.facebook.com/docs/plugins/page-plugin/

This updates to the new recommended attribute.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 11, 2019
@jeherve jeherve added this to the 7.9 milestone Oct 11, 2019
@jeherve jeherve requested a review from a team October 11, 2019 12:27
@jeherve jeherve self-assigned this Oct 11, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33919-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Oct 11, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 56cc1b7

ChaosExAnima
ChaosExAnima previously approved these changes Oct 23, 2019
View reviewed changes
@ChaosExAnima
Copy link
Contributor

Looks good, but confirmation on whether we need a copy change would be nice.

@ChaosExAnima ChaosExAnima added [Status] Needs Copy Review Copy has been added. Marketing will be notified for a copy review. and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 23, 2019
@michelleweber
Copy link

I'd change to "timeline," which I think is more generally used/understood, esp in the context of FB.

@matticbot
Copy link
Contributor

jeherve, Your synced wpcom patch D33919-code has been updated.

@jeherve
Copy link
Member Author

jeherve commented Oct 24, 2019

Done in 56cc1b7. Thank you!

image

This should be ready for another review.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Copy Review Copy has been added. Marketing will be notified for a copy review. labels Oct 24, 2019
kbrown9
kbrown9 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@kbrown9 kbrown9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested using the provided testing instructions, and everything looks good!

@kbrown9 kbrown9 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Oct 25, 2019
@kraftbj kraftbj merged commit 8f87bd7 into master Oct 25, 2019
@kraftbj kraftbj deleted the fix/fb-page-plugin-stream branch October 25, 2019 21:54
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 25, 2019
jeherve added a commit that referenced this pull request Oct 28, 2019
@jeherve
Changelog: add #13725
bbad173
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrown9 kbrown9 kbrown9 approved these changes

@ChaosExAnima ChaosExAnima ChaosExAnima left review comments

Assignees

@jeherve jeherve

Labels
[Feature] Extra Sidebar Widgets Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.

Facebook Page Plugin widget stream missing
7 participants
@jeherve @matticbot @jetpackbot @ChaosExAnima @michelleweber @kbrown9 @kraftbj