Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Debug: Do not fail if WP.com SELF test times outs. #13530

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Sep 24, 2019

Fixes #12881

The "WP.com SELF Test" pings WordPress.com and requests the Jetpack.com/support/debug/ test suite ran, then reports the result. To allow time for all of the work, the HTTP timeout is increased to 30 seconds. Sometimes this isn't long enough either because the site is slow or simply slower to reach over the network.

Previously, a timeout when requesting the SELF test resulted in a test failure, reporting as such in the Site Health section of a WordPress site.

Now, a timeout will not fail out the test and won't be reported on Site Health.

Next steps would be evaluate this test and the REST API-based connection test to only require one.

Changes proposed in this Pull Request:

  • Debug: Self test no longer fails on a timeout.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • n/a

Testing instructions:

  • Add add_filter( 'http_request_timeout', function () { return 1; } ), 999 ); to your site (to reduce the HTTP timeout to 1 second.
  • Visit the Tools->Site Health page.
  • Prior to this PR, a really generic error would be reported for Jetpack.
  • With this PR, no error is returned.

Proposed changelog entry for your changes:

  • Debug: Reduce instances when an inconclusive response would result in an error.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended General [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". labels Sep 24, 2019
@kraftbj kraftbj added this to the 7.9 milestone Sep 24, 2019
@kraftbj kraftbj requested a review from a team September 24, 2019 15:25
@kraftbj kraftbj self-assigned this Sep 24, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against f93d282

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 24, 2019
@kraftbj kraftbj merged commit 714f982 into master Sep 24, 2019
@kraftbj kraftbj deleted the fix/12881-timeouts branch September 24, 2019 15:34
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 24, 2019
jeherve added a commit that referenced this pull request Oct 23, 2019
jeherve added a commit that referenced this pull request Oct 29, 2019
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". General [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugger / Site Health Displaying False-Positive Errors
4 participants