Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: do not display Composing header for editors. #13542

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Admin Page: do not display Composing header for editors. #13542

merged 2 commits into from
Sep 30, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 25, 2019

Changes proposed in this Pull Request:

  • Editors do not need that header anymore, since the After The Deadline module doesn't exist anymore.

Before

image

After

image

Testing instructions:

  • Go to Users > Add New, and create a new editor role for your site.
  • Log in with that editor, and go to Jetpack > Settings
  • You should not see any lonely "Composing" heading.

Proposed changelog entry for your changes:

  • Admin Page: do not display Composing header for editors.

@jeherve
Admin Page: do not display Composing header for editors.
9e476f3 
Editors do not need that header anymore, since the After The Deadline module doesn't exist anymore.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Sep 25, 2019
@jeherve jeherve added this to the 7.9 milestone Sep 25, 2019
@jeherve jeherve requested a review from a team September 25, 2019 13:10
@jeherve jeherve self-assigned this Sep 25, 2019
@jetpackbot
Copy link

jetpackbot commented Sep 25, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against e534729

@kraftbj kraftbj force-pushed the fix/composing-tab-editors branch 2 times, most recently from a3a34fc to 841fae4 Compare September 30, 2019 21:06
@kraftbj kraftbj added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! Unit Tests and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 30, 2019
@kraftbj

This comment has been minimized.

Sign in to view
@kraftbj kraftbj force-pushed the fix/composing-tab-editors branch from 841fae4 to e534729 Compare September 30, 2019 21:26
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Sep 30, 2019
@kraftbj kraftbj merged commit 2c8ad23 into master Sep 30, 2019
@kraftbj kraftbj deleted the fix/composing-tab-editors branch September 30, 2019 21:38
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 30, 2019
jeherve added a commit that referenced this pull request Oct 23, 2019
@jeherve
Changelog: add #13542
79d3fa6
jeherve added a commit that referenced this pull request Oct 29, 2019
@jeherve
7.9: Changelog (#13608)
6cd1621 
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Bug When a feature is broken and / or not performing as intended Unit Tests
Projects
None yet
Milestone
7.9
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @jetpackbot @kraftbj @matticbot