-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed Block Bottom Sheet to set a link #3436
Conversation
Hey @ceyhun . 👋🏻 We will cut the 1.52.0 release Friday 30 April. Please let me know if you're aiming to include this PR in 1.52.0. Otherwise perhaps we can add the milestone label for 1.53.0 Thanks! 🙇 |
# Conflicts: # gutenberg
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
@hypest The GB-mobile PR of "Embed Block Bottom Sheet to set a link" is ready for review, it only contains the Gutenberg ref and a release notes update, thanks 🙇 ! |
RELEASE-NOTES.txt
Outdated
@@ -1,5 +1,6 @@ | |||
Unreleased | |||
------ | |||
* [*] Embed Block Bottom Sheet to set a link [https://github.com/wordpress-mobile/gutenberg-mobile/pull/3436] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my understanding is that the embed block is still behind the dev flag, right? If we keep it that the release notes mention will be confusing, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, yeah it's behind a dev flag so makes sense not to include it in the release notes 👍 .
I verified if we already included entries related to the embed block and I found this one:
gutenberg-mobile/RELEASE-NOTES.txt
Line 39 in b5c31ba
* [*] Generic Embed Block placeholder UI [https://github.com/wordpress-mobile/gutenberg-mobile/pull/3346] |
So probably we should remove it too, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah, let's remove them. Technically speaking, those were already published to the Stores, but better to remove from the release notes files. Thanks for reviewing the past entries!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just removed all the entries in the release notes related to the embed block in this commit.
Oops, sorry about missing to review this gb-mobile side PR. Left a comment here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #3274
To test: WordPress/gutenberg#31343
PR submission checklist: