-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed Block Bottom Sheet to set a link #3436
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a3d6e97
Update gutenberg ref
ceyhun e7dada0
Merge branch 'develop' into add/3274-embed-block-bottom-sheet
ceyhun eeeec6c
Merge branch 'develop' into add/3274-embed-block-bottom-sheet
fluiddot 77a79cc
Update Gutenberg ref
fluiddot 5d127f0
Merge branch 'develop' into add/3274-embed-block-bottom-sheet
fluiddot b7444a2
Update Gutenberg ref
fluiddot 9cd0f4c
Update Gutenberg ref with merge commit
fluiddot 2f3ca26
Update release notes
fluiddot b0555a1
Merge branch 'develop' into add/3274-embed-block-bottom-sheet
fluiddot 867a5dc
Remove embed block entries from release notes
fluiddot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule gutenberg
updated
6 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, my understanding is that the embed block is still behind the dev flag, right? If we keep it that the release notes mention will be confusing, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, yeah it's behind a dev flag so makes sense not to include it in the release notes 👍 .
I verified if we already included entries related to the embed block and I found this one:
gutenberg-mobile/RELEASE-NOTES.txt
Line 39 in b5c31ba
So probably we should remove it too, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah, let's remove them. Technically speaking, those were already published to the Stores, but better to remove from the release notes files. Thanks for reviewing the past entries!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just removed all the entries in the release notes related to the embed block in this commit.