[RN Mobile] Audio Block: Add from URL - Refactor Prompt component [WIP] #31853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
Hey @ceyhun when you get a chance could you have a look at this approach and share any thoughts you may have? If necessary I can add more screenshots and details if any of the states described aren't clear. Thanks 😄 |
@ceyhun this is not urgent. I know you are focusing on the RN upgrade so your availability is limited right now. @fluiddot I will need your help with reviewing these changes when it is best for you. |
jd-alexander
commented
May 18, 2021
Comment on lines
+262
to
+266
| <AddFromUrlBottomSheet | ||
| onClose={ ( { url } ) => { | ||
| this.setState( { | ||
| isAddFromUrlBottomsheetVisible: false, | ||
| } ); |
There was a problem hiding this comment.
I'm not sure I like handling the state for the bottom sheet here. I wanted to encapsulate it within the AddFromUrlBottomSheet the issue I was having was the AddFromUrlBottomSheet is a function component while the MediaUpload is a class component, so the ref ideas I had weren't clear to me. Let me know what you think. This sheet is based on #31343
|
I will be closing this PR since we were able to get the prompt component working as expected and it is tested and functioning fine on both platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft mode - I will create the GB Mobile PR in short order.
Description
The purpose of this PR is to migrate from the
promptcomponent in #27817 to thelink settingsbottom sheet behavior. This move was inspired by the implementation done in Embed Block Bottom Sheet to set a link. The current implementation of the prompt component that creates a polyfill so there can be Android support for theAlert.promptAPI is causing crashes related to Hermes and so far it has been difficult to debug the issue, hence the usage of a component that is already cross-platform.How has this been tested?
Screenshots
Types of changes
Issues Noticed
Some issues have been noticed that may be as a result of how the Link component is built.
Checklist:
*.native.jsfiles for terms that need renaming or removal).