Test PR for gb-mobile audio block add from URL prompt #14675
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APK here. |
| @@ -2288,7 +2288,7 @@ private GutenbergPropsBuilder getGutenbergPropsBuilder() { | |||
| enableXPosts, | |||
| isUnsupportedBlockEditorEnabled, | |||
| unsupportedBlockEditorSwitch, | |||
| !isFreeWPCom, // Disable audio block until it's usable on free sites via "Insert from URL" capability | |||
| true, //!isFreeWPCom, // Disable audio block until it's usable on free sites via "Insert from URL" capability | |||
There was a problem hiding this comment.
Reporter: CheckStyle
Rule: com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck
Severity: ERROR
File: /home/circleci/project/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java L2291
Line comments // must be followed by one whitespace
| @@ -2288,7 +2288,7 @@ private GutenbergPropsBuilder getGutenbergPropsBuilder() { | |||
| enableXPosts, | |||
| isUnsupportedBlockEditorEnabled, | |||
| unsupportedBlockEditorSwitch, | |||
| !isFreeWPCom, // Disable audio block until it's usable on free sites via "Insert from URL" capability | |||
| true, //!isFreeWPCom, // Disable audio block until it's usable on free sites via "Insert from URL" capability | |||
There was a problem hiding this comment.
Reporter: CheckStyle
Rule: com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck
Severity: ERROR
File: /home/circleci/project/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java L2291
Line is longer than 120 characters (found 125).
|
👋 @jd-alexander , I created this new set of WPAndroid and gb-mobile PRs to test out the popup prompt Gutenberg PR for the Audio block and looks like the binaries produced here are not crashing on editor-open like in #13833 (comment). Can you try as well? Thanks! I tried both a locally built vanillaRelease and the the installable build https://106186-9306568-gh.circle-artifacts.com/0/Artifacts/WordPress-pr-14675-build-106186.apk and the editor works fine. Just for easy testing, I've enabled the audio block for all sites, and not meaning to merge these PRs. |
Awesome! I tested it and I can confirm that it works. I am wondering what changed 🤔 |
|
I am updating the main gutenberg-mobile PR with this approach so that that the WP Android PR can be used to test the changes in the PR. Thanks for the help with this. I am wondering if the issue was due to bintray build failure. |
|
Closing as this PR is not needed anymore. |
This is a test PR to try out wordpress-mobile/gutenberg-mobile#3518
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.