Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Block: Add from URL #3031

Merged
merged 16 commits into from
May 21, 2021
Merged

Audio Block: Add from URL #3031

merged 16 commits into from
May 21, 2021

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Jan 20, 2021

Gutenberg PR WordPress/gutenberg#27817
WP Android PR wordpress-mobile/WordPress-Android#13833
To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jd-alexander jd-alexander added this to the 1.46 (16.7) milestone Jan 20, 2021
@fluiddot
Copy link
Contributor

fluiddot commented Feb 1, 2021

👋 @jd-alexander, we're cutting the release now so I'll bump this to 1.47. Please let me know if you think it needs to be included in this release and we can arrange that.

@fluiddot fluiddot modified the milestones: 1.46 (16.7), 1.47 (16.8) Feb 1, 2021
@dcalhoun
Copy link
Member

@jd-alexander we are cutting a release later today, so I am bumping this to 1.48.0. Please let me know if you think we should work to include this in 1.47.0 instead. We can make a plan to include it.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 23, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux
Copy link
Contributor

geriux commented Mar 1, 2021

Hey @jd-alexander 👋 we are cutting a release later today, so I am bumping this to 1.49.0. Please let us know if you think we should work to include this in 1.48.0 instead. Thanks!

@geriux geriux modified the milestones: 1.48.0 (16.9), 1.49.0 (17.0) Mar 1, 2021
@chipsnyder
Copy link
Contributor

Hey @jd-alexander 👋 I'm working on cutting the 1.49.0 release, so I am bumping this out of 1.49.0.

I cleared the milestone since it seems to have shifted a few times now but please let me know if you think we should work to include this in 1.49.0 instead. Thanks!

@chipsnyder chipsnyder removed this from the 1.49.0 (17.0) milestone Mar 15, 2021
@jd-alexander
Copy link
Contributor Author

I will fix the Android PR to test this behavior once the binary has been generated successfully.

@jd-alexander jd-alexander marked this pull request as ready for review April 20, 2021 05:29
@jd-alexander jd-alexander added this to the 1.52.0 (17.3) milestone Apr 20, 2021
@cameronvoell
Copy link
Contributor

Hey @jd-alexander. 👋🏻 We will cut the 1.52.0 release Friday 30 April. I plan to circle back and bump this PR to the next milestone (1.53.0) on Friday, but please let me know if you'd rather us work to include this PR in 1.52.0. Thanks! 🙇

@ceyhun
Copy link
Contributor

ceyhun commented May 14, 2021

Hey there @jd-alexander 👋 We'll be cutting the 1.53.0 release some time soon today. I'm bumping this PR to 1.54.0 milestone, please let us know if it needs to make it into 1.53.0 instead.

@ceyhun ceyhun modified the milestones: 1.53.0 (17.4), 1.54.0 (17.5) May 14, 2021
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-alexander jd-alexander enabled auto-merge May 21, 2021 05:19
@jd-alexander jd-alexander merged commit 897bf7f into develop May 21, 2021
@jd-alexander jd-alexander deleted the add/audio-block-IV-from-url branch May 21, 2021 05:45
@jhnstn jhnstn mentioned this pull request May 28, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants