[Gutenberg] Audio Block - Add From URL - React Native Prompt Android Integration #13833

jd-alexander · 2021-01-20T19:47:30Z

gutenberg mobile PR wordpress-mobile/gutenberg-mobile#3031
gutenberg PR WordPress/gutenberg#27817

Solution

Introduces the Insert From URL functionality to the Audio Block via a Native Alert Dialog on Android. This library react-native-prompt-android was needed because the Alert.prompt functionality in React Native doesn't work out of the box in Android. So on iOS, an input alert component is presented so this library acts a polyfill for the Alert.prompt API in React Native, so that we can utilize the same APIs in code but we will have true cross platform support.

Testing

Dark Mode	Light Mode

Reviewing

Only 1 reviewer is needed but anyone can review.

Submitter Checklist

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
I have considered adding accessibility improvements for my changes.
If it's feasible, I have added unit tests.

peril-wordpress-mobile · 2021-01-20T19:47:37Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2021-01-20T19:47:38Z

	Warnings
⚠️	PR is missing at least one label.

Generated by 🚫 dangerJS

peril-wordpress-mobile · 2021-01-21T21:57:13Z

You can test the changes on this Pull Request by downloading the APK here.

JavonDavis · 2021-02-08T21:52:21Z

Hey @jd-alexander! Bumping this to 16.8, if you'd like to get it in for this release please merge this into release/16.7 and then DM me to release a new Beta version.

JavonDavis · 2021-03-08T17:51:46Z

Hey again @jd-alexander! Bumping this to 17.0, if you'd like to get it in for this release please merge this into release/16.9 and then DM me to release a new Beta version.

jd-alexander · 2021-04-08T05:25:50Z

The block editor is crashing here. I will investigate this more tomorrow.

jd-alexander · 2021-04-29T16:51:58Z

@ceyhun I created issues for the remaining tasks here I will be addressing. I am currently waiting on the Android PR for this to build so I can test it to verify that all is well with the new Android component it is utilizing and then it's good to go.

jd-alexander · 2021-04-29T17:54:15Z

I am getting this crash when I attempt to open the editor.

  
    --------- beginning of crash
2021-04-29 12:15:24.011 15094-15375/org.wordpress.android.prealpha A/libc: Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x69006c in tid 15375 (mqt_js), pid 15094 (ndroid.prealpha)
2021-04-29 12:15:24.153 15384-15384/? A/DEBUG: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
2021-04-29 12:15:24.154 15384-15384/? A/DEBUG: Build fingerprint: 'google/sdk_gphone_x86_arm/generic_x86_arm:11/RSR1.201013.001/6903271:userdebug/dev-keys'
2021-04-29 12:15:24.154 15384-15384/? A/DEBUG: Revision: '0'
2021-04-29 12:15:24.154 15384-15384/? A/DEBUG: ABI: 'x86'
2021-04-29 12:15:24.154 15384-15384/? A/DEBUG: Timestamp: 2021-04-29 12:15:24-0500
2021-04-29 12:15:24.154 15384-15384/? A/DEBUG: pid: 15094, tid: 15375, name: mqt_js  >>> org.wordpress.android.prealpha <<<
2021-04-29 12:15:24.154 15384-15384/? A/DEBUG: uid: 10154
2021-04-29 12:15:24.154 15384-15384/? A/DEBUG: signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x69006c
2021-04-29 12:15:24.154 15384-15384/? A/DEBUG:     eax 0069006c  ebx a893aadc  ecx a78436a0  edx eb0de500
2021-04-29 12:15:24.155 15384-15384/? A/DEBUG:     edi a893aadc  esi a78436a0
2021-04-29 12:15:24.155 15384-15384/? A/DEBUG:     ebp a78435a8  esp a7843590  eip a876373a
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG: backtrace:
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #00 pc 0001b73a  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libhermes.so (BuildId: 6edffcdc58850c69f3cfe5b067de1187988a97cc)
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #01 pc 00018929  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libhermes.so (BuildId: 6edffcdc58850c69f3cfe5b067de1187988a97cc)
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #02 pc 000187ee  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libhermes.so (facebook::hermes::makeHermesRuntime(hermes::vm::RuntimeConfig const&)+49) (BuildId: 6edffcdc58850c69f3cfe5b067de1187988a97cc)
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #03 pc 00019e4d  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libhermes-executor-release.so (facebook::react::HermesExecutorFactory::createJSExecutor(std::__ndk1::shared_ptr<facebook::react::ExecutorDelegate>, std::__ndk1::shared_ptr<facebook::react::MessageQueueThread>)+61) (BuildId: 555a1f151ae008230fc4743239203136c2e6ab97)
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #04 pc 0009c2c8  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libreactnativejni.so (facebook::react::NativeToJsBridge::NativeToJsBridge(facebook::react::JSExecutorFactory*, std::__ndk1::shared_ptr<facebook::react::ModuleRegistry>, std::__ndk1::shared_ptr<facebook::react::MessageQueueThread>, std::__ndk1::shared_ptr<facebook::react::InstanceCallback>)+216) (BuildId: 930803d0b368271f5f896b0cefe51d5c5c2e92b3)
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #05 pc 00093fca  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libreactnativejni.so (std::__ndk1::__compressed_pair_elem<facebook::react::NativeToJsBridge, 1, false>::__compressed_pair_elem<facebook::react::JSExecutorFactory*&&, std::__ndk1::shared_ptr<facebook::react::ModuleRegistry>&, std::__ndk1::shared_ptr<facebook::react::MessageQueueThread>&, std::__ndk1::shared_ptr<facebook::react::InstanceCallback>&, 0u, 1u, 2u, 3u>(std::__ndk1::piecewise_construct_t, std::__ndk1::tuple<facebook::react::JSExecutorFactory*&&, std::__ndk1::shared_ptr<facebook::react::ModuleRegistry>&, std::__ndk1::shared_ptr<facebook::react::MessageQueueThread>&, std::__ndk1::shared_ptr<facebook::react::InstanceCallback>&>, std::__ndk1::__tuple_indices<0u, 1u, 2u, 3u>)+154) (BuildId: 930803d0b368271f5f896b0cefe51d5c5c2e92b3)
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #06 pc 00093d06  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libreactnativejni.so (BuildId: 930803d0b368271f5f896b0cefe51d5c5c2e92b3)
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #07 pc 00062089  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libreactnativejni.so (BuildId: 930803d0b368271f5f896b0cefe51d5c5c2e92b3)
2021-04-29 12:15:24.262 15384-15384/? A/DEBUG:       #08 pc 0005fe15  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libreactnativejni.so (BuildId: 930803d0b368271f5f896b0cefe51d5c5c2e92b3)
2021-04-29 12:15:24.263 15384-15384/? A/DEBUG:       #09 pc 0004ee42  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libreactnativejni.so (facebook::jni::detail::MethodWrapper<void (facebook::react::JNativeRunnable::*)(), &(facebook::react::JNativeRunnable::run()), facebook::react::JNativeRunnable, void>::dispatch(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::react::JNativeRunnable, facebook::react::Runnable>::JavaPart, facebook::react::Runnable, void>::_javaobject*>)+50) (BuildId: 930803d0b368271f5f896b0cefe51d5c5c2e92b3)
2021-04-29 12:15:24.263 15384-15384/? A/DEBUG:       #10 pc 0004eda9  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libreactnativejni.so (facebook::jni::detail::FunctionWrapper<void (*)(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::react::JNativeRunnable, facebook::react::Runnable>::JavaPart, facebook::react::Runnable, void>::_javaobject*>), &(facebook::jni::detail::MethodWrapper<void (facebook::react::JNativeRunnable::*)(), &(facebook::react::JNativeRunnable::run()), facebook::react::JNativeRunnable, void>::dispatch(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::react::JNativeRunnable, facebook::react::Runnable>::JavaPart, facebook::react::Runnable, void>::_javaobject*>)), facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::react::JNativeRunnable, facebook::react::Runnable>::JavaPart, facebook::react::Runnable, void>::_javaobject*, void>::call(_JNIEnv*, _jobject*)+73) (BuildId: 930803d0b368271f5f896b0cefe51d5c5c2e92b3)
2021-04-29 12:15:24.263 15384-15384/? A/DEBUG:       #11 pc 0004ed53  /data/app/~~bVgpEdfKq0ZHCU1d4zPX9w==/org.wordpress.android.prealpha-wkwcbzMXYCIdr-8G5IY2CQ==/lib/x86/libreactnativejni.so (facebook::jni::detail::MethodWrapper<void (facebook::react::JNativeRunnable::*)(), &(facebook::react::JNativeRunnable::run()), facebook::react::JNativeRunnable, void>::call(_JNIEnv*, _jobject*)+35) (BuildId: 930803d0b368271f5f896b0cefe51d5c5c2e92b3)
2021-04-29 12:15:24.263 15384-15384/? A/DEBUG:       #12 pc 00142132  /apex/com.android.art/lib/libart.so (art_quick_generic_jni_trampoline+82) (BuildId: 8191579dfafff37a5cbca70f

jd-alexander · 2021-05-19T05:23:30Z

The error with Hermes has been resolved by utilizing the latest gutenberg-mobile build from S3.

jd-alexander · 2021-05-21T05:20:14Z

This PR can be closed as it was a test PR for wordpress-mobile/gutenberg-mobile#3031

jd-alexander mentioned this pull request Jan 20, 2021

Audio Block: Add from URL wordpress-mobile/gutenberg-mobile#3031

Merged

2 tasks

jd-alexander modified the milestones: 16.6, 16.7 Jan 20, 2021

Base automatically changed from gutenberg/audio_block_consolidated_media_picker_integration to develop January 28, 2021 22:17

JavonDavis modified the milestones: 16.7, 16.8 Feb 8, 2021

jd-alexander modified the milestones: 16.8, 16.9 Feb 18, 2021

JavonDavis modified the milestones: 16.9, 17.0 Mar 8, 2021

JavonDavis modified the milestones: 17.0, 17.1 Mar 22, 2021

JavonDavis modified the milestones: 17.1, 17.2 Apr 5, 2021

jd-alexander closed this Apr 8, 2021

jd-alexander force-pushed the gutenberg/audio_block_add_from_url branch from 23cadbc to 314356d Compare April 8, 2021 04:40

jd-alexander reopened this Apr 8, 2021

JavonDavis modified the milestones: 17.2, 17.3 Apr 19, 2021

JavonDavis modified the milestones: 17.3, 17.4 May 3, 2021

JavonDavis modified the milestones: 17.4, 17.6 May 17, 2021

hypest mentioned this pull request May 18, 2021

Test PR for gb-mobile audio block add from URL prompt #14675

Closed

3 tasks

Updated gutenberg-mobile ref.

8535510

jd-alexander force-pushed the gutenberg/audio_block_add_from_url branch from eecb562 to 8535510 Compare May 19, 2021 04:27

jd-alexander closed this May 21, 2021

jkmassel deleted the gutenberg/audio_block_add_from_url branch October 17, 2024 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gutenberg] Audio Block - Add From URL - React Native Prompt Android Integration #13833

[Gutenberg] Audio Block - Add From URL - React Native Prompt Android Integration #13833

jd-alexander commented Jan 20, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Jan 20, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Jan 20, 2021

peril-wordpress-mobile bot commented Jan 21, 2021 •

edited

Loading

JavonDavis commented Feb 8, 2021

JavonDavis commented Mar 8, 2021

jd-alexander commented Apr 8, 2021

jd-alexander commented Apr 29, 2021

jd-alexander commented Apr 29, 2021

jd-alexander commented May 19, 2021

jd-alexander commented May 21, 2021

[Gutenberg] Audio Block - Add From URL - React Native Prompt Android Integration #13833

[Gutenberg] Audio Block - Add From URL - React Native Prompt Android Integration #13833

Conversation

jd-alexander commented Jan 20, 2021 • edited Loading

Solution

Testing

Reviewing

Submitter Checklist

peril-wordpress-mobile bot commented Jan 20, 2021 • edited Loading

peril-wordpress-mobile bot commented Jan 20, 2021

peril-wordpress-mobile bot commented Jan 21, 2021 • edited Loading

JavonDavis commented Feb 8, 2021

JavonDavis commented Mar 8, 2021

jd-alexander commented Apr 8, 2021

jd-alexander commented Apr 29, 2021

jd-alexander commented Apr 29, 2021

jd-alexander commented May 19, 2021

jd-alexander commented May 21, 2021

jd-alexander commented Jan 20, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Jan 20, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Jan 21, 2021 •

edited

Loading