Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed Block Implement caption field #3552

Merged
merged 11 commits into from
Jul 2, 2021
Merged

Embed Block Implement caption field #3552

merged 11 commits into from
Jul 2, 2021

Conversation

jd-alexander
Copy link
Contributor

Fixes #3282

To test:
WordPress/gutenberg#32226

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jd-alexander jd-alexander mentioned this pull request May 25, 2021
Merged
7 tasks
@jd-alexander jd-alexander marked this pull request as draft May 26, 2021 03:10
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 30, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot self-assigned this Jun 30, 2021
@fluiddot fluiddot marked this pull request as ready for review June 30, 2021 17:30
@fluiddot fluiddot requested a review from hypest June 30, 2021 17:30
hypest
hypest reviewed Jul 1, 2021
View reviewed changes
RELEASE-NOTES.txt Outdated
@@ -1,6 +1,7 @@
Unreleased
------
* [*] Update loading and failed screens for web version of the editor [https://github.com/wordpress-mobile/gutenberg-mobile/pull/3573]
* [*] Embed Block Implement caption field [https://github.com/wordpress-mobile/gutenberg-mobile/pull/3552]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #3436 (comment), we should delay adding the embed block release notes until we unveil it from behind the dev flag.

hypest
hypest approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fluiddot , I'll LGTM the PR to match my LGTM of the Gutenberg side PR too, especially since I will be away tomorrow and don't want to block the PR. But, I've left a message about the release notes entry that we need to remove since the block is still behind the DEV flag so, please address that comment and feel free to merge after addressing.

@fluiddot
Copy link
Contributor

fluiddot commented Jul 1, 2021

Hey @fluiddot , I'll LGTM the PR to match my LGTM of the Gutenberg side PR too, especially since I will be away tomorrow and don't want to block the PR. But, I've left a message about the release notes entry that we need to remove since the block is still behind the DEV flag so, please address that comment and feel free to merge after addressing.

Ok, thank you very much for the review ❤️ ! I've just updated the release notes in this commit.

@fluiddot fluiddot merged commit 3ac797f into develop Jul 2, 2021
@fluiddot fluiddot deleted the issue-3282/embed-block-caption branch July 2, 2021 15:17
@fluiddot fluiddot added this to the 1.57.0 (17.8) milestone Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Task
Projects
None yet
Milestone
1.57.0 (17.8)
Development

Successfully merging this pull request may close these issues.

[Embed block] Implement caption field
3 participants
@jd-alexander @fluiddot @hypest