Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embed block] Implement Bottom Sheet to set a link #3274

Closed
ceyhun opened this issue Mar 17, 2021 · 0 comments · Fixed by #3436
Closed

[Embed block] Implement Bottom Sheet to set a link #3274

ceyhun opened this issue Mar 17, 2021 · 0 comments · Fixed by #3436

Comments

@ceyhun
Copy link
Contributor

ceyhun commented Mar 17, 2021

Description

  • Implement Bottom Sheet to set a link for Embed block
  • When a block placeholder is added, bottom sheet is automatically opened
  • Link field is auto-focused (labeled “Embed link”)
  • If there is a link in the clipboard it is auto-pasted
  • Can type a link if empty
  • Can close before typing and re-open by pressing on the embed block placeholder
  • Can open by pressing the pen icon in the toolbar when an existing embed block is selected
  • Can click on the “Learn more about embeds” link at the bottom to open the support article in the browser: https://wordpress.org/support/article/embeds/
  • Close the bottom sheet after typing a link. If the link is not a valid URL, a warning message is shown

Screenshot

Existing Placeholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants