Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woo 2.0 Brand Updates #13254

Draft
wants to merge 128 commits into
base: trunk
Choose a base branch
from
Draft

Woo 2.0 Brand Updates #13254

wants to merge 128 commits into from

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 8, 2025

Part of: woocommerce/woomobile-private#373

Description

This PR merges the main feature branch of Brand Updates project (pffQ75-10m-p2) into trunk.

Steps to reproduce

Smoke test (P91TBi-bVe-p2)

Testing information

Please test both the light and dark modes.

The tests that have been performed

All the commits here have already been tested in other PRs.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

Removed purple colors were already Woo Purple colors in color-studio.blog. There's no need to keep purple and WooPurple.
These images are not necessary.
These are removed because they're the same for all build variants.
Our minSdk is 36 now, so we don't need -c26 suffix anymore.
Removed purple colors were already Woo Purple colors in color-studio.blog. There's no need to keep purple and WooPurple.
irfano and others added 18 commits January 4, 2025 14:07
Renamed the icon and added its dark version.
…lustration

Update the tap card illustration
…ers-empty-image

Update top performers card empty image
…gin-screen-design

Update prologue login screen design
…or-illustration

Update generic error illustration
@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 8, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 8, 2025

2 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 8, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit18662a5
Direct Downloadwoocommerce-wear-prototype-build-pr13254-18662a5.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 8, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit18662a5
Direct Downloadwoocommerce-prototype-build-pr13254-18662a5.apk

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 40.68%. Comparing base (0137ab7) to head (18662a5).
Report is 53 commits behind head on trunk.

Files with missing lines Patch % Lines
.../android/ui/woopos/common/composeui/WooPosTheme.kt 0.00% 18 Missing ⚠️
...woocommerce/android/ui/prefs/AboutConfigBuilder.kt 0.00% 8 Missing ⚠️
...oocommerce/android/wear/compose/theme/WooColors.kt 0.00% 5 Missing ⚠️
.../woocommerce/android/ui/compose/theme/WooColors.kt 0.00% 3 Missing ⚠️
...i/products/selector/components/SelectorListItem.kt 0.00% 3 Missing ⚠️
...rce/android/ui/compose/component/FeedbackDialog.kt 0.00% 2 Missing ⚠️
...rce/android/ui/compose/component/SelectionCheck.kt 0.00% 2 Missing ⚠️
.../topperformers/DashboardTopPerformersWidgetCard.kt 0.00% 2 Missing ⚠️
...woocommerce/android/ui/compose/component/QRCode.kt 0.00% 1 Missing ⚠️
...ndroid/ui/login/jetpack/components/JetpackToWoo.kt 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13254      +/-   ##
============================================
+ Coverage     40.67%   40.68%   +0.01%     
  Complexity     6396     6396              
============================================
  Files          1351     1351              
  Lines         77664    77638      -26     
  Branches      10682    10682              
============================================
  Hits          31587    31587              
+ Misses        43291    43265      -26     
  Partials       2786     2786              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android Lint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

hafizrahman and others added 4 commits January 8, 2025 13:27
@wpmobilebot
Copy link
Collaborator

Project dependencies changes

Content exceeds 65400 characters. Navigate to Buildkite build artifacts to see details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants