Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme colors #13147

Merged
merged 14 commits into from
Dec 17, 2024
Merged

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Dec 16, 2024

Closes: woocommerce/woomobile-private#381
Closes: woocommerce/woomobile-private#402

Description

This PR updates the Woo purple colors of the app according to the v4.0.0 of https://color-studio.blog/.
No test was added since this only changes colors.

Steps to reproduce

Just run the app and view as many screens as possible.

Testing information

Please also test in the dark mode to check for any contrast issues. Design file to compare: Ntkk0ER4hHt5y9KjEGIiGk-fi-2481_1556

The tests that have been performed

Viewed some screens.

Images/gif

splash my-store orders products reviews reviews-dark payments collect-payment
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added type: task An internally driven task. category: design Layout and style elements in the UI or user interface, including color and animations. labels Dec 16, 2024
@irfano irfano added this to the 21.6 milestone Dec 16, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6f234e4
Direct Downloadwoocommerce-wear-prototype-build-pr13147-6f234e4.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6f234e4
Direct Downloadwoocommerce-prototype-build-pr13147-6f234e4.apk

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 40.45%. Comparing base (71e0fae) to head (6f234e4).
Report is 15 commits behind head on feature/woo-2.0-brand-updates.

Files with missing lines Patch % Lines
.../android/ui/woopos/common/composeui/WooPosTheme.kt 0.00% 17 Missing ⚠️
...oocommerce/android/wear/compose/theme/WooColors.kt 0.00% 4 Missing ⚠️
.../woocommerce/android/ui/compose/theme/WooColors.kt 0.00% 3 Missing ⚠️
...rce/android/ui/compose/component/FeedbackDialog.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##             feature/woo-2.0-brand-updates   #13147      +/-   ##
===================================================================
+ Coverage                            40.43%   40.45%   +0.01%     
  Complexity                            6230     6230              
===================================================================
  Files                                 1302     1302              
  Lines                                75458    75429      -29     
  Branches                             10358    10358              
===================================================================
  Hits                                 30513    30513              
+ Misses                               42285    42256      -29     
  Partials                              2660     2660              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hafizrahman hafizrahman self-assigned this Dec 17, 2024
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current code changes look good so I'm pre-approving. Please check my next comment for my findings and areas where we might want to improve.

@hafizrahman
Copy link
Contributor

Product filter > Product type Product details: dark Product details: light
2024-12-17 13 22 02 2024-12-17 13 21 56 2024-12-17 13 21 59
Explore text maybe should be white? "Write with AI" purple on gray is hard to read. Maybe should be white? "Got it" purple on gray is hard to read. Maybe should be white?

@irfano
Copy link
Contributor Author

irfano commented Dec 17, 2024

Thanks, Hafiz! Good feedback!

Explore text maybe should be white?

Good catch! I think it was a bug since the button didn’t have style. I’ve updated it.
Your other comments about the purple button on a dark background are part of a broader topic, as we use it on many screens. I’ll share your feedback with Wagner.

@irfano irfano merged commit 5e95707 into feature/woo-2.0-brand-updates Dec 17, 2024
15 checks passed
@irfano irfano deleted the feature/update-theme-colors branch December 17, 2024 10:35
@@ -178,7 +150,7 @@ private val DarkColorPalette = darkColors(
)

private val LightColorPalette = lightColors(
primary = WooPosColors.Purple50,
primary = WooPosColors.WooPurple50,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irfano I see that you kept the pruple50 for the POS theme, I didn't do any updates yet in iOS, so I wanted to ask if we should confirm with design whether we should change the POS them to use purple40 too or to keep it like this, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked to see if there’s any reason to use a different theme for WooPos, but it looks like there isn’t. (p1734456791340939/1734454071.869999-slack-C025A8VV728) So, I’ll update the primary color to Purple 40.

@wagveloso
Copy link

wagveloso commented Dec 17, 2024

Hi there! I think we can work on finding a good solution.

The purple graphics, like the CTA, pass on the contrast check for both, dark gray and black backgounds. However, the text needs to be white on them.

For links, normal text on dark backgrounds, my recommendation is to go with white, because the purple is not creating a good contrast and not passing on the contrast checker. However, I believe that changing all the links to white will add a lot of work for you guys.

What you think we should do?

@irfano
Copy link
Contributor Author

irfano commented Dec 17, 2024

However, I believe that changing all the links to white will add a lot of work for you guys.

@wagveloso, yes, it’s a big task. If we change all the purple text to white, it will make it harder to differentiate certain elements, such as headers and list items, in some cases. So, I think this would be a significant change for the app.

We currently use Purple 30 for dark mode. What if we apply the same for Woo 2.0? I’ll share some examples. Do you think it improves contrast?

Purple 40 Purple 30

@wagveloso
Copy link

Thanks for sharing the screens! Purple 30 looks much better @irfano . I vote for using Purple 30.

@irfano
Copy link
Contributor Author

irfano commented Dec 18, 2024

I agree! It looks better. Then we’ll update it to Purple 30 for dark mode.

@irfano irfano mentioned this pull request Dec 22, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants