-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme colors #13147
Update theme colors #13147
Conversation
Removed purple colors were already Woo Purple colors in color-studio.blog. There's no need to keep purple and WooPurple.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/woo-2.0-brand-updates #13147 +/- ##
===================================================================
+ Coverage 40.43% 40.45% +0.01%
Complexity 6230 6230
===================================================================
Files 1302 1302
Lines 75458 75429 -29
Branches 10358 10358
===================================================================
Hits 30513 30513
+ Misses 42285 42256 -29
Partials 2660 2660 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current code changes look good so I'm pre-approving. Please check my next comment for my findings and areas where we might want to improve.
@@ -178,7 +150,7 @@ private val DarkColorPalette = darkColors( | |||
) | |||
|
|||
private val LightColorPalette = lightColors( | |||
primary = WooPosColors.Purple50, | |||
primary = WooPosColors.WooPurple50, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irfano I see that you kept the pruple50 for the POS theme, I didn't do any updates yet in iOS, so I wanted to ask if we should confirm with design whether we should change the POS them to use purple40 too or to keep it like this, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked to see if there’s any reason to use a different theme for WooPos, but it looks like there isn’t. (p1734456791340939/1734454071.869999-slack-C025A8VV728) So, I’ll update the primary color to Purple 40.
Hi there! I think we can work on finding a good solution. The purple graphics, like the CTA, pass on the contrast check for both, dark gray and black backgounds. However, the text needs to be white on them. For links, normal text on dark backgrounds, my recommendation is to go with white, because the purple is not creating a good contrast and not passing on the contrast checker. However, I believe that changing all the links to white will add a lot of work for you guys. What you think we should do? |
@wagveloso, yes, it’s a big task. If we change all the purple text to white, it will make it harder to differentiate certain elements, such as headers and list items, in some cases. So, I think this would be a significant change for the app. We currently use Purple 30 for dark mode. What if we apply the same for Woo 2.0? I’ll share some examples. Do you think it improves contrast?
|
Thanks for sharing the screens! Purple 30 looks much better @irfano . I vote for using Purple 30. |
I agree! It looks better. Then we’ll update it to Purple 30 for dark mode. |
Closes: woocommerce/woomobile-private#381
Closes: woocommerce/woomobile-private#402
Description
This PR updates the Woo purple colors of the app according to the v4.0.0 of https://color-studio.blog/.
No test was added since this only changes colors.
Steps to reproduce
Just run the app and view as many screens as possible.
Testing information
Please also test in the dark mode to check for any contrast issues. Design file to compare: Ntkk0ER4hHt5y9KjEGIiGk-fi-2481_1556
The tests that have been performed
Viewed some screens.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: