Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dark version of ic_not_found icon #13253

Merged

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 7, 2025

Part of: woocommerce/woomobile-private#379

Description

This updates the not found icon color for the dark mode.

Steps to reproduce

  1. Tap the calendar icon on the "Top performers" card.
  2. Select an empty day.

The tests that have been performed

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 7, 2025
@irfano irfano requested a review from hichamboushaba January 7, 2025 14:24
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit05b2f58
Direct Downloadwoocommerce-wear-prototype-build-pr13253-05b2f58.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit05b2f58
Direct Downloadwoocommerce-prototype-build-pr13253-05b2f58.apk

@irfano irfano requested review from hafizrahman and JorgeMucientes and removed request for hichamboushaba January 8, 2025 14:01
@JorgeMucientes JorgeMucientes self-assigned this Jan 9, 2025
Copy link
Contributor

@JorgeMucientes JorgeMucientes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@irfano irfano merged commit 4eaea61 into feature/woo-2.0-brand-updates Jan 9, 2025
16 checks passed
@irfano irfano deleted the feature/update-not-found-icon-color branch January 9, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants