-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update top performers card empty image #13243
Update top performers card empty image #13243
Conversation
Renamed the icon and added its dark version.
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/woo-2.0-brand-updates #13243 +/- ##
================================================================
Coverage 40.59% 40.59%
- Complexity 6372 6373 +1
================================================================
Files 1345 1345
Lines 77235 77235
Branches 10602 10602
================================================================
+ Hits 31352 31353 +1
Misses 43135 43135
+ Partials 2748 2747 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good here in my tests.
Closes: woocommerce/woomobile-private#379
Description
This updates the empty illustration for the "Top performers" card
Steps to reproduce
Testing information
The tests that have been performed
Tested the Top performers card and empty product case in Woo Pos for both dark and light mode.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: