Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update About library version #13263

Merged

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 8, 2025

Closes: woocommerce/woomobile-private#388

Description

This updates the about library. The new version includes new Woo logo and removes WP logo.

Steps to reproduce

  1. Go to Menu → Settings → WooCommerce

Testing information

Test both light and dark mode.

The tests that have been performed

Steps above.

Images/gif

Before After
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 8, 2025
@wpmobilebot
Copy link
Collaborator

Project dependencies changes

Content exceeds 65400 characters. Navigate to Buildkite build artifacts to see details.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commite2a0587
Direct Downloadwoocommerce-wear-prototype-build-pr13263-e2a0587.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commite2a0587
Direct Downloadwoocommerce-prototype-build-pr13263-e2a0587.apk

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 40.68%. Comparing base (3bc342f) to head (e2a0587).
Report is 4 commits behind head on feature/woo-2.0-brand-updates.

Files with missing lines Patch % Lines
...woocommerce/android/ui/prefs/AboutConfigBuilder.kt 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##             feature/woo-2.0-brand-updates   #13263      +/-   ##
===================================================================
- Coverage                            40.68%   40.68%   -0.01%     
  Complexity                            6396     6396              
===================================================================
  Files                                 1351     1351              
  Lines                                77634    77638       +4     
  Branches                             10682    10682              
===================================================================
  Hits                                 31587    31587              
- Misses                               43261    43265       +4     
  Partials                              2786     2786              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hafizrahman hafizrahman self-assigned this Jan 9, 2025
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can see the right changes both in light and dark mode.

@hafizrahman hafizrahman merged commit 18662a5 into feature/woo-2.0-brand-updates Jan 9, 2025
16 checks passed
@hafizrahman hafizrahman deleted the feature/update-about-library branch January 9, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants