Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Future] 7.0 Release Plan #3062

Closed
35 of 70 tasks
michael-hawker opened this issue Nov 13, 2019 · 23 comments
Closed
35 of 70 tasks

[Future] 7.0 Release Plan #3062

michael-hawker opened this issue Nov 13, 2019 · 23 comments

Comments

@michael-hawker
Copy link
Member

michael-hawker commented Nov 13, 2019

7.0 Release Plan

Main Theme: Release focused on dependency streamlining and clean-up to make pieces of the toolkit more consumable. (Includes clean-up and prep for WinUI 3)

Secondary Themes:

  • Animations and Composition-level XAML Helpers (ThemeShadow, XamlLight, DropShadow, etc...)

7.0.0-preview4 on NuGet - NOTE 7.0 of the toolkit will contain many breaking changes, preview packages may change frequently, we'll try and keep posts updated here with changes. For instance, 7.0.0-preview1 now uses DispatcherQueue over Dispatcher

The plan

7.0 Dev Branch Here make any breaking changes here (will be merged to master soon).

Milestone
Feature Board
Bug Board
 
Below is a summary of the top level plan items. These items are in addition to everything that was initially released with the preview.
 
Legend of annotations:

Symbol Description
Help Wanted
0️⃣ priority 0 - must have for this release
1️⃣ priority 1 - nice to have for this release
2️⃣ priority 2 - stretch goal - unlikely for this release but we will try our best
missing issue reference
🔦 investigating

Planning/Discussions

  • Finalize ColorCode Migration/Transition
  • Package Names/Namespaces for WinUI Future

Technical Debt

Refactors

New Features

Bugs

  • 🔦 Investigate main bugs to call out we want to prioritize here above others.
  • Infinite Canvas

Remove Previously Deprecated Components

Remove upcoming Deprecated Components?

Since this is a major release, we could release note these, but should decide if we want to or not still.

  • NotifyTaskCompletion?
  • RssParser - System.ServiceModel.Syndication is just as easy to use and an official .NET package, we should remove this. See Doc Issue
  • RadialProgressBar, WinUI 2.5 has a Determinite ProgressRing, should identify if any gaps.

Deprecate Services

Not sure if we should have a cycle to deprecate these, but they don't work currently, so may just remove?

There's also solutions like RestSharp and Refit {.NET Foundation}, I think the biggest problem still seems like simplifying the Authentication step/process...

@michael-hawker michael-hawker added the feature request 📬 A request for new changes to improve functionality label Nov 13, 2019
@ghost ghost added the needs triage 🔍 label Nov 13, 2019
@ghost
Copy link

ghost commented Nov 13, 2019

Thanks for submitting a new feature request! I've automatically added a vote reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

@ToddThomson
Copy link

@michael-hawker Is the ContentSizer control going to be part of this release?

I just learned about ( and installed ) the XAML Studio app. Great Garage project! I read that you used the ContentSizer in the app. Can you use the ContentSizer with a SplitView? I am also interested in what Editor control you used ( for line numbers, etc ). Thanks in advance!

@michael-hawker
Copy link
Member Author

@ToddThomson added it to the list 😉; I may just need to take a weekend and add it in...

I haven't tried ContentSizer it with SplitView, only with Expander, so that's part of the work to do too.

The editor control is the same one we use in the toolkit sample app, it's a wrapper around the VS Code Monaco control, it's repo is here. XAML Studio just has more features built on top of it. Eventually, hopefully, I'll be able to open source XAML Studio and then re-incorporate those improvements to our sample app.

@ToddThomson
Copy link

@michael-hawker The ContentSizer would be great a great addition. Thank-you!

I am currently adding the GridSpitter to the outside columns of a 3 column panel grid (UserControl). In the XAML Studio app, your LHS NavView control can be resized when the NavPane is open ( the Sizer is collapsed when the NavPane is closed ). I am hoping that the new ContentSizer will allow me control its visibility property like you have done.

@hez2010
Copy link

hez2010 commented Feb 1, 2020

Could you please DO NOT deprecate TabView?
The new TabView in WinUI is verrrrrrry ugly and its design is NOT "fluent" at all. If you use WinUI TabView in a NavigationView especially while using acrylic brush, you will find that the new TabView is completely mismatch the whole Fluent Design style.

@michael-hawker
Copy link
Member Author

Thanks for the concern @hez2010, can you add your feedback and examples to the WinUI TabView vNext thread here? FYI @stmoy

We do want to make sure the WinUI control is a valid replacement for the toolkit one before we deprecate it, we know it's not quite there yet, but we hope that by the time we do 7.0 later this year, the next iteration of the WinUI TabView will be completed.

@ghost ghost added in progress 🚧 and removed for-review 📖 To evaluate and validate the Issues or PR labels Mar 2, 2020
@jhwheuer
Copy link

jhwheuer commented Mar 9, 2020

If it is not too late yet... I am really missing a OnCropChanged event in the ImageCropper...
I would like to provide to the user a pixel dimension information about the Rect she currently crops to... All that event would have to do is fire when the crop has changed, it does not even have to transmit the new crop Rect....

@Sergio0694
Copy link
Member

Small note as per comment in #3131: the ColorHelper.ToHex extension should be renamed ToHexString for consistency with other APIs in the Microsoft.Toolkit package.

For quick reference:

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/d85e1a7bc084bba02e83c728386269e42fd382c5/Microsoft.Toolkit.Uwp/Helpers/ColorHelper.cs#L124-L132

@ranjeshj
Copy link
Contributor

ranjeshj commented Sep 1, 2020

Regarding feature parity of RadialProgressBar and the WinUI 2.5 ProgressRing, the only missing APIs are:

  • Outline: Gets or sets the color of the circular outline on which the segment is drawn
  • Thickness: Gets or sets the thickness of the circular outline and segment

Those two customization options are not yet available with the WinUI 2.5 ProgressRing. There is already a tracking issue for the color customizations, however I don't think there is a tracking issue for the thickness property. @YuliKl @ranjeshj @MarissaMatt FYI

In ProgressRing, Foreground/Background properties are tied to ring and background. We currently do not expose the thickness, but you there is the ability to swap out the entire Lottie animation (using DeterminateSource/InDeterminateSource properties). Given that level of customization is available, do we need the thickness exposed as a property ?

ghost pushed a commit that referenced this issue Sep 11, 2020
Removed:
* Major components:
  * TabView/TabViewItem
  * HeaderedTextBlock
  * FacebookService and Microsoft.Toolkit.Uwp.Services project
  * RSS Parsers
* Smaller methods:
  * StringExtensions.ToSafeString
  * LinkedIn, Twitter and Weibo sync Logout methods.
  * ConnectedAnimations.SetListDataItemForNextConnectedAnnimation
  * TileControl.IsCompositionSupported
  * NotifyTaskCompletion
  * Singleton

This is still missing the update on the docs repo.

## Contributes towards #3062
## Fixes #3396

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

<!-- - Bugfix -->
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
- Other... Please describe: Removing dead code.


## What is the current behavior?
Obsolete classes marked as obsolete, but still exist in code.

## What is the new behavior?
Some classes/methods marked as obsolete are now removed from code.

## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [X] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [ ] Contains **NO** breaking changes

This PR IS a breaking change, as instead of just providing a warning, any developers that uses the dead code will now get missing method/class exceptions.
@MarissaMatt
Copy link

@chingucoding sorry for the delay but I created a new issue to track adding a thickness property. microsoft/microsoft-ui-xaml#3293

ghost pushed a commit that referenced this issue Sep 22, 2020
…on paths. (#3478)

Also, removed any WinJS reference.

## Fixes #3440

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

- Build or CI related changes

## What is the current behavior?
Target SDK = 18362
Min SDK = 16299

## What is the new behavior?
Target SDK = 19041
Min SDK = 17763

## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [X] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [ ] Contains **NO** breaking changes

This PR does have breaking changes, as expected by #3062.
@yoshiask
Copy link
Contributor

Is 17763 going to be the final min SDK version for 7.0?

@michael-hawker
Copy link
Member Author

@yoshiask Yup, 17763 (1809) is the min version we'll be using for 7.x.

ghost pushed a commit that referenced this issue Oct 27, 2020
## Part of #3062, related to #3435 
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->

<!-- Add a brief overview here of the feature/bug & fix. -->

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

- Optimization
- Deprecation
<!-- - Bugfix -->
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
The `Microsoft.Toolkit` package has a number of extensions for 2D arrays that are inefficient (they're both a bit slow and causing unnecessary memory allocations) and replaced by equivalent APIs in the `Microsoft.Toolkit.HighPerformance` package.

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/30452cf0bbf627f12825cf50bbd31b0e526b9abe/Microsoft.Toolkit/Extensions/ArrayExtensions.cs#L27

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/30452cf0bbf627f12825cf50bbd31b0e526b9abe/Microsoft.Toolkit/Extensions/ArrayExtensions.cs#L48

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/30452cf0bbf627f12825cf50bbd31b0e526b9abe/Microsoft.Toolkit/Extensions/ArrayExtensions.cs#L68

## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->
This PR makes these APIs obsolete, and also includes a number of small optimizations to existing code that was added during the refactoring to remove dependencies on these APIs, so that it'll be possible to remove them in the future with no issues.

## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [ ] ~~Sample in sample app has been added / updated (for bug fixes / features)~~
    - [ ] ~~Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)~~
- [X] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [X] Contains **NO** breaking changes
@michael-hawker michael-hawker unpinned this issue Nov 18, 2020
@michael-hawker michael-hawker pinned this issue Nov 24, 2020
@ghost ghost added in progress 🚧 and removed for-review 📖 To evaluate and validate the Issues or PR labels Jan 6, 2021
ghost pushed a commit that referenced this issue Feb 18, 2021
…sBar (#3758)

## Contributes to #3062 
Adds deprecation message to the RadialProgressBar. Updates some of our dependencies. Few more to do, but will wait until we remove parsers and services packages.
@ghost ghost removed the in progress 🚧 label Mar 4, 2021
@michael-hawker
Copy link
Member Author

Alright, think we can close this issue, we got to a ton of things, but not everything on our original list. We'll spin up a 7.1 one soon.

Almost there. 🎉🎉🎉

@michael-hawker michael-hawker unpinned this issue Mar 16, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests