Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Toolkit Platform Analyzers #3396

Closed
1 task
michael-hawker opened this issue Jul 22, 2020 · 1 comment · Fixed by #3435
Closed
1 task

Remove Toolkit Platform Analyzers #3396

michael-hawker opened this issue Jul 22, 2020 · 1 comment · Fixed by #3435
Labels
Completed 🔥 maintenance ⚙️
Milestone
7.0

Comments

@michael-hawker
Copy link
Member

Describe the bug

We don't have a good way to determine a project's targets so our platform analyzers can't work effectively. This was an oversight we didn't realize when we first built them. See discussion and comments here

With that in mind, we'll remove them from the toolkit for 7.0 and follow-up with the platform/SDK team to implement this based on the CsWinRT issue/discussion here.

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:
@michael-hawker michael-hawker added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jul 22, 2020
@michael-hawker michael-hawker added this to the 7.0 milestone Jul 22, 2020
@ghost ghost added the needs triage 🔍 label Jul 22, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

Hello michael-hawker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@michael-hawker michael-hawker added maintenance ⚙️ and removed bug 🐛 An unexpected issue that highlights incorrect behavior needs triage 🔍 labels Jul 22, 2020
This was referenced Jul 22, 2020
Closed
Closed
Closed
@michael-hawker michael-hawker mentioned this issue Aug 18, 2020
Merged
7 tasks
azchohfi added a commit that referenced this issue Aug 18, 2020
@azchohfi
Remove Toolkit Platform Analyzers (fixes #3396).
5b7d04b
@ghost ghost added the In-PR 🚀 label Aug 18, 2020
@ghost ghost closed this as completed in #3435 Sep 11, 2020
ghost pushed a commit that referenced this issue Sep 11, 2020
Removed Deprecated for 7.0 (#3435)
1b08bd6 
Removed:
* Major components:
  * TabView/TabViewItem
  * HeaderedTextBlock
  * FacebookService and Microsoft.Toolkit.Uwp.Services project
  * RSS Parsers
* Smaller methods:
  * StringExtensions.ToSafeString
  * LinkedIn, Twitter and Weibo sync Logout methods.
  * ConnectedAnimations.SetListDataItemForNextConnectedAnnimation
  * TileControl.IsCompositionSupported
  * NotifyTaskCompletion
  * Singleton

This is still missing the update on the docs repo.

## Contributes towards #3062
## Fixes #3396

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

<!-- - Bugfix -->
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
- Other... Please describe: Removing dead code.


## What is the current behavior?
Obsolete classes marked as obsolete, but still exist in code.

## What is the new behavior?
Some classes/methods marked as obsolete are now removed from code.

## PR Checklist

Please check if your PR fulfills the following requirements:

- [X] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [X] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [X] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [ ] Contains **NO** breaking changes

This PR IS a breaking change, as instead of just providing a warning, any developers that uses the dead code will now get missing method/class exceptions.
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Sep 11, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Completed 🔥 maintenance ⚙️
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

Removed Deprecated for 7.0 CommunityToolkit/WindowsCommunityToolkit
1 participant
@michael-hawker