Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]RotatorTile OnCurrentItemChanging #2994

Closed
SeakyLuo opened this issue Sep 2, 2019 · 7 comments
Closed

[Feature]RotatorTile OnCurrentItemChanging #2994

SeakyLuo opened this issue Sep 2, 2019 · 7 comments
Labels
controls 🎛️ feature request 📬 A request for new changes to improve functionality good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software help wanted Issues identified as good community contribution opportunities

Comments

@SeakyLuo
Copy link

SeakyLuo commented Sep 2, 2019

Describe the problem this feature would solve

I want to change the background of my Grid where RotatorTile lies, when the image in the RotatorTile is changing. Having OnCurrentItemChanging would be very helpful for solving this issue. Another issue this would solve is that I want my image to have a random rotating direction.

Describe the solution

I am expecting a function like
void OnCurrentItemChanging(object sender, RotatorTileItemChangedArgs args)
where args will inform me of the next item and even allow me to cancel the change.

Describe alternatives you've considered

I can use binding but that's inefficient I think, because I only need to change one part (background) of my control and I don't need to change others. But currently I need to put everything into the ItemTemplate.

@SeakyLuo SeakyLuo added the feature request 📬 A request for new changes to improve functionality label Sep 2, 2019
@ghost ghost added the needs triage 🔍 label Sep 2, 2019
@michael-hawker michael-hawker added this to the 6.0 milestone Sep 3, 2019
@michael-hawker michael-hawker added Hacktoberfest Hacktoberfest is a month-long celebration of open source software help wanted Issues identified as good community contribution opportunities labels Sep 27, 2019
@michael-hawker michael-hawker modified the milestones: 6.0, 6.1 Oct 30, 2019
@michael-hawker michael-hawker added the good first issue Issues identified as good for first-time contributors label Apr 2, 2020
@Kyaa-dost
Copy link
Contributor

@SeakyLuo Is this something you would like to work on by creating a PR? We are still seeking assistance on this by community members but if you want to start you are more than welcome 🙂

@SeakyLuo
Copy link
Author

Cool, I will try when I am available. @Kyaa-dost

@Kyaa-dost
Copy link
Contributor

@SeakyLuo any update on this? We are fast approaching our 6.1 release and tomorrow is the last day of code submission.

@SeakyLuo
Copy link
Author

Sorry for late response. I have a little bit trouble with pushing my code. So I put it here.

I apologize in advance if my code does not follow your coding convention.

@michael-hawker
Copy link
Member

Thanks @SeakyLuo, do you need some assistance in getting setup with the Toolkit repo?

I created a YouTube video here about building the toolkit itself.

Let us know how we can help you get setup.

For now, I'll move this to our next milestone as we're closing out our current release.

@michael-hawker michael-hawker modified the milestones: 6.1, 7.0 Jun 4, 2020
@Kyaa-dost
Copy link
Contributor

@SeakyLuo Thanks for all the work! Did you have a chance to take check out Michael's video above? Please let us know of an update and we can still push this in our upcoming 7.0 release.

@Kyaa-dost Kyaa-dost added in progress 🚧 and removed help wanted Issues identified as good community contribution opportunities labels Jan 12, 2021
@Kyaa-dost
Copy link
Contributor

@SeakyLuo will be moving this to our 7.1 release.

@Kyaa-dost Kyaa-dost modified the milestones: 7.0, 7.1 Feb 17, 2021
@ghost ghost removed the in progress 🚧 label Feb 17, 2021
@Kyaa-dost Kyaa-dost removed the Hacktoberfest Hacktoberfest is a month-long celebration of open source software label May 6, 2021
@michael-hawker michael-hawker added the help wanted Issues identified as good community contribution opportunities label Sep 17, 2021
@michael-hawker michael-hawker modified the milestones: 7.1, 7.2/8.0? Sep 17, 2021
@ghost ghost removed this from the 7.2/8.0? milestone Sep 17, 2021
@michael-hawker michael-hawker added the Hacktoberfest Hacktoberfest is a month-long celebration of open source software label Oct 7, 2021
@CommunityToolkit CommunityToolkit locked and limited conversation to collaborators Jul 29, 2022
@LalithaNadimpalli LalithaNadimpalli converted this issue into discussion #4671 Jul 29, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
controls 🎛️ feature request 📬 A request for new changes to improve functionality good first issue Issues identified as good for first-time contributors Hacktoberfest Hacktoberfest is a month-long celebration of open source software help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

3 participants