Add new 'DesignTools' projects #3318
Conversation
|
Thanks Nirmal4G for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
added
feature request 📬
Microsoft.Toolkit.Uwp.UI.Controls.DataGrid.Design/MetadataRegistration.cs
Outdated
Show resolved
Hide resolved
...wp.UI.Controls.DataGrid.Design/Microsoft.Toolkit.Uwp.UI.Controls.DataGrid.DesignTools.csproj
Show resolved
Hide resolved
Nirmal4G
force-pushed
the
feature/design-tools
branch
from
ca37481 to
66e841a
Compare
|
@Nirmal4G any update on this? |
Nirmal4G
force-pushed
the
feature/design-tools
branch
from
66e841a to
5762d01
Compare
Nirmal4G
force-pushed
the
feature/design-tools
branch
from
5762d01 to
d11909b
Compare
Nirmal4G
force-pushed
the
feature/design-tools
branch
from
d11909b to
6c1bac0
Compare
|
@Nirmal4G see you have some commits here, are you expecting more changes or should we try to test this out in its current state? |
|
@michael-hawker I still have that problem where I need an alternative solution to using the XML Doc. Tried a few things, I might have something working as a potential replacement. Will update here once it's ready for review. |
|
Feel free to test it out. From this point it's just fixes and metadata additions for more controls. |
Microsoft.Toolkit.Uwp.UI.Controls.Design/MetadataRegistration.cs
Outdated
Show resolved
Hide resolved
Nirmal4G
force-pushed
the
feature/design-tools
branch
from
6c1bac0 to
757bc97
Compare
Nirmal4G
force-pushed
the
feature/design-tools
branch
3 times, most recently
from
8fb133b to
263eab3
Compare
Nirmal4G
force-pushed
the
feature/design-tools
branch
from
263eab3 to
42bc139
Compare
|
Yeah... I'm looking into it. Some changes between now and then broke it when I rebased on top of the latest master. Found the issue: PR #3450 created smoke tests and the project file used older I renamed the property names and that should let the tests build properly now. |
Nirmal4G
force-pushed
the
feature/design-tools
branch
from
078bc12 to
9019a28
Compare
|
Thanks so much @Nirmal4G for being on top of updates this morning! 🎉🎉🎉 We'll take a look at vetting the NuGets which have generated now and see how things are working. It'll be great to finally get this all together. Thanks so much again for your patience in getting this together for us, it's been very much appreciated. 🦙❤ @RosarioPulella want to do an initial pass next of updating to these PR NuGets in a fresh VS project and seeing how things work in the Designer with VS 2019 16.8.2? |
There was a problem hiding this comment.
Looking good! Not sure why @Nirmal4G, but I couldn't see the MarkdownTextBlock in the Toolbox. I can't see an obvious reason why something would be different here? Main package and DataGrid seemed to work fine.
Can you also add a Wiki Page for this under the Development/Testing section with some guidance on how this project is setup and how someone would go about modifying info here or adding data for a new control? For instance are the Typedata files just hand-crafted copies?
@azchohfi can you take a quick glance at the prop/target file changes? Otherwise, I'm good with this once we tweak the MarkdownTextBlock package.
Microsoft.Toolkit.Uwp.UI.Controls.Design/Controls/TextToolbar.Typedata.cs
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI.Controls/Microsoft.Toolkit.Uwp.UI.Controls.csproj
Show resolved
Hide resolved
michael-hawker
dismissed
azchohfi’s stale review
Going to fix-forward after and get this merged.
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
This should merge after the build, created #3620 to follow-up on remaining small open issues. |
ghost
merged commit
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Fixes #3252
Created the
DesignToolsprojects and refactored the code to work with the new XAML Designer.BothDesignandDesignToolsprojects live SxS (Side by Side) now, so that, we can ship for both the designers for the foreseeable future.Reason: It was decided that we don't need to support older Designer anymore.
Part of #3062
More info in each of the commits' description.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Design tools don't work well with our controls (after VS v16.4 upgrade) because of the new XAML designer.
What is the new behavior?
Now the design tools should work as before as the new
DesignToolsprojects have been introduced to work with the new XAML designer.PR Checklist
Please check if your PR fulfils the following requirements:
Other information
Conversion to Sdk-style, adding more metadata and using source generators (once enough docs/samples available) to do it, will come in later PRs.