Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-3155: Updating link validation tests #1127

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Nov 22, 2024

Jira ticket

Vote-3155

Description

Updating link validation tests:

  • Internal link -> setting up check to ensure that internal links do not have a trailing /
  • both tests -> setting up to both hit the prod url, this is due to the pipeline running on prod and needed to check the live site for any broken links

Deployment and testing

Post-deploy steps

n/a

QA/Testing instructions

Please take a look at the file and check the comment at the top in regards to the baseurl

  1. log into the site and update a link on the home page (i suggest a link in the Quicklinks section) and adding a trailing /
  2. cd into testing and run npm run cy:open and select the internal links test from the cypress runner and verify that the test is failing on the home page due to the trailing /

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review November 22, 2024 16:17
@SamiraMSadat SamiraMSadat merged commit 8d786e4 into dev Nov 22, 2024
2 checks passed
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
@rayestrada rayestrada deleted the qa/vote-3155-internal-link-check branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants