Vote-3155: Updating link validation tests (#1127)

usagov · Nov 22, 2024 · 8d786e4 · 8d786e4
1 parent e1cd44b
commit 8d786e4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/testing/cypress/e2e/externalLinks/external-links-validator.cy.js b/testing/cypress/e2e/externalLinks/external-links-validator.cy.js
@@ -1,6 +1,8 @@
 /// <reference types="Cypress" />
 
 const allPages = require("../../fixtures/site-pages.json");
+// ! IMPORTANT: When testing locally, comment out the LIVE_URL and use the LOCAL_URL listed below for testing purposes. This is necessary because our pipeline testing targets the live site. Remember to revert this change before committing, ensuring the LIVE_URL is set as the base.
+// const baseUrl = "http://vote-gov.lndo.site/";
 
 const baseUrl = "https://vote.gov";
 const excludedLinks = [

diff --git a/testing/cypress/e2e/internalLinks/internal-links-validator.cy.js b/testing/cypress/e2e/internalLinks/internal-links-validator.cy.js
@@ -1,6 +1,14 @@
 /// <reference types="Cypress" />
 
 const allPages = require("../../fixtures/site-pages.json");
+// ! IMPORTANT: When testing locally, comment out the LIVE_URL and use the LOCAL_URL listed below for testing purposes. This is necessary because our pipeline testing targets the live site. Remember to revert this change before committing, ensuring the LIVE_URL is set as the base.
+// const baseUrl = "http://vote-gov.lndo.site/";
+
+const baseUrl = "https://vote.gov";
+const excludedLinks = [
+  'http://vote-gov.lndo.site/',
+  'https://vote.gov'
+];
 
 describe("Internal Link Validator Test", () => {
   const singlePage =
@@ -14,7 +22,7 @@ describe("Internal Link Validator Test", () => {
       : null;
   const pages = singlePage !== null ? singlePage : allPages;
   pages.forEach((page) => {
-    it( 
+    it(
       `${page.name === "" ? "home" : page.name}`,
       () =>
         Cypress.env("retries") === true
@@ -25,18 +33,20 @@ describe("Internal Link Validator Test", () => {
             }
           : {},
       () => {
-        cy.visit({
-          url: page.route,
-        });
+        cy.visit(`${baseUrl}${page.route}`);
           cy.get("a[href^='/']").each(link => {
+            const href = link.prop("href");
+            if (excludedLinks.indexOf(href) === -1) {
+            expect(href).not.match(/\/$/);
             cy.request({
               url: link.prop('href'),
               failOnStatusCode: false
             }).then((response) => {
               expect(response.status).to.eq(200)
             })
+          }
         })
       }
     );
-  });    
-});
+  });
+});