Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-3059 add new field to nvrf report listing and export #1122

Merged
merged 1 commit into from
Nov 20, 2024
Merged

VOTE-3059 add new field to nvrf report listing and export #1122

merged 1 commit into from
Nov 20, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Nov 20, 2024 •
edited by SamiraMSadat
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3059

Description

Add state mail-in PDF link to nvrf report page and export.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. log in and visit http://vote-gov.lndo.site/admin/nvrf-state-report and see there is a new column for state mail-in pdf link
  2. visit http://vote-gov.lndo.site/admin/nvrf-state-report/export and check the csv to make sure the state mail-in pdf link data is last column

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat merged commit e1cd44b into dev Nov 20, 2024
2 checks passed
tt-gsa added a commit that referenced this pull request Nov 27, 2024
@tt-gsa @clmedders
@SamiraMSadat @rayestrada
Testing/vote 2963 testing (#1137)
beaad4e 
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
@tt-gsa @clmedders
@SamiraMSadat @rayestrada
Testing/vote 2963 testing (#1138)
297600d 
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
@tt-gsa @clmedders
@SamiraMSadat @rayestrada
Testing/vote 2963 testing (#1140)
4cd1a2a 
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
@rayestrada rayestrada deleted the feature/VOTE-3059-nvrf-report-mod branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @SamiraMSadat