Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-3142: Remove when:always flag #1134

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Nov 26, 2024

Jira ticket

Vote-3142

Description

Removing the when:always flag from the config.yml file.. according to CircleCi Docs there is no need for an always flag since it will run no matter what unless you need to set a time. Such as on fail or something else.

Deployment and testing

Post-deploy steps

n/a

QA/Testing instructions

  1. Review file and ensure there are no when:always flags present

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders requested a review from tt-gsa November 26, 2024 14:26
@tt-gsa tt-gsa merged commit 2df2ad6 into dev Nov 26, 2024
2 checks passed
@tt-gsa tt-gsa deleted the feature/vote-3142-remove-when-flag branch November 26, 2024 15:26
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants