Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-3081 Remove underline, text align, and not allowed tags #1112

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Nov 15, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3081

Description

Remove the underline and text-align buttons from the toolbar.
Remove the no longer allowed custom classes.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Login as admin
  2. Create a new basic page
  3. Confirm the underline and text align buttons are removed from the wysiwg.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Copy link
Contributor

@clmedders clmedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@rayestrada rayestrada dismissed clmedders’s stale review November 19, 2024 01:27

Changes are approved

@rayestrada rayestrada merged commit 7958a1b into dev Nov 19, 2024
2 checks passed
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
tt-gsa added a commit that referenced this pull request Nov 27, 2024
* Vote-3106: Bug fixes for RTL styles (#1099)

* VOTE-3081 Remove underline, text-align from allowed tags (#1112)

* VOTE-3108 resolve regression in nvrf template (#1121)

Co-authored-by: tt-gsa <[email protected]>

* VOTE-3059 add new field to nvrf report listing and export (#1122)

* Vote-3155: Updating link validation tests (#1127)

* Vote-3142: Remove when:always flag (#1134)

* VOTE-2963: update conditions for running downsync workflows

* testing

* testing

---------

Co-authored-by: Christian Medders - Bixal <[email protected]>
Co-authored-by: SamiraMSadat <[email protected]>
Co-authored-by: Ray Estrada <[email protected]>
@rayestrada rayestrada deleted the feature/VOTE-3081/wysiwg-basic-remove-options branch December 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants