Pick macro parameters in an infinite editor like content type properties #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 2, 2019 23:21
…r to select parameter editor.
bjarnef
changed the title
|
Thanks @bjarnef, we'll have a look! Adding descriptions and group names to the |
|
@nul800sebastiaan yes, the property editors also use a I think we can start with this and enhance it later. Furthermore I don't think we need to request macro partial views when loading a macro, but we can change this in another PR. |
nul800sebastiaan
changed the title
nul800sebastiaan
added
hacktoberfest/contrib-2019
and removed
state/hq-discussion-cms
labels
|
This is lovely work @bjarnef! Many thanks, it all works wonderfully! ⭐️ 💪 |
emmaburstow
pushed a commit
that referenced
this pull request
Oct 27, 2019
…ton (#6561) * Improves accessability of the three dot tree options button * Updated list view headers styling to have the link/hand cursor visible only if the header is sortable (and hence clicking has an effect) * Allows members to be ordered by additional system fields (#6575) * Fix ContentType.Alias matching in PublishedContentExtensions an… (#6577) * Fixes an error in #6538 by moving the colon character to the sr-only span * V8: Move misplaced colon in language selector (#6692) * V8: It should be possible to disallow all types at content root (#6580) * Pick macro parameters in an infinite editor like content type properties (#6586) * Reload node children after publishing with descendants * Correct URL decoding of macro partial view names (#6592) * Fix semantics for list views (#6595) * fixes test * fixing tests * Improved menu context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #4318
Description
This PR adjust to macro parameters to be more consistent with manage properties and their datatypes on document types, media types and member types.
It also don't request parameter editors, before you want to edit or add a parameter.
At the moment the parameters doesn't have info about the "datatype name", so it make a request here. Not sure if it is easy to extend the
MacroParameterDisplaywith aDataTypeNameor similar property here?https://github.com/umbraco/Umbraco-CMS/blob/v8/dev/src/Umbraco.Web/Editors/MacrosController.cs#L119-L125
It would be great if the macro parameters also supported description as well, so you can add a description like on properties for document, media and member types.