Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macroparameterpicker.controller.js has a couple of console.log calls #9516

Closed
leekelleher opened this issue Dec 8, 2020 · 4 comments · Fixed by #9533
Closed

macroparameterpicker.controller.js has a couple of console.log calls #9516

leekelleher opened this issue Dec 8, 2020 · 4 comments · Fixed by #9533

Comments

@leekelleher
Copy link
Member

Whilst dev'ing my Contentment package, I'd spotted a couple of console.log calls in the "macroparameterpicker.controller.js", leftovers from development I guess.

https://github.com/umbraco/Umbraco-CMS/blob/release-8.9.1/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/macroparameterpicker/macroparameterpicker.controller.js#L106-L107

I haven't had time to resolve this yet, but thought it best to log it - also could be a "good first issue" one?

Umbraco version

I am seeing this issue on Umbraco version: 8.6.6, but noticed that it's still in 8.9.1, and was introduced in 8.4.0.

Reproduction

For reproduction steps, follow the steps from PR #6586.

Steps to reproduce

Go to a Macro, click Parameters app, add a new parameter, select a editor, check the dev tools console.

Expected result

I'd expect not to see the console.log calls.

Actual result

I see the console.log calls.

@nul800sebastiaan
Copy link
Member

Sure thing, that shouldn't be there! We'd love a little help. 😃

@umbrabot
Copy link

umbrabot commented Dec 9, 2020

Hi @leekelleher,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)

glombek pushed a commit that referenced this issue Dec 11, 2020
* #9516 removed console logging statements in macroparemeter picker

* #9516 Removed another console log statement

* Removed console log statement from view
@glombek
Copy link
Contributor

glombek commented Dec 11, 2020

Fixed in #9533

@glombek glombek added community/pr release/8.11.0 release/no-notes This is too small to add to the release notes or fixed after a beta/RC and removed community/up-for-grabs labels Dec 11, 2020
@nul800sebastiaan nul800sebastiaan removed the release/no-notes This is too small to add to the release notes or fixed after a beta/RC label Jan 19, 2021
@nul800sebastiaan
Copy link
Member

FYI: I moved the labels to the PR so the contributor gets their face featured on the release page!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants