Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/Issue - Improving accessibility of the three dot tree options button #6561

Merged
merged 15 commits into from
Oct 27, 2019
Merged

WIP/Issue - Improving accessibility of the three dot tree options button #6561

merged 15 commits into from
Oct 27, 2019

Conversation

Matthew-Wise
Copy link
Contributor

@Matthew-Wise Matthew-Wise commented Oct 2, 2019

Prerequisites

Work towards - #5277

Description

Improving the context for screen reader users of the three dot tree options button
image

The change fixes most cases of this tree option. However it does not accurately reflect the dialog in the following cases:

Content

  • Recycle bin

Media

  • Recycle bin

Settings

  • Member Types
    • Children
  • Macros
    • Children
  • Related Types
    • Children
  • Content Templates

Templating

  • Templates
    • Children

Members

  • Member groups
    • Children

Translate

  • Dictionary item

Am not sure what the best approach to take for these areas

Any feedback would be great! (I have also asked the community team to take a look as well)

Matt

@nul800sebastiaan
Copy link
Member

Thanks @Matthew-Wise - we'll have a look 👍

@Matthew-Wise
Copy link
Contributor Author

Had a chat with @zersiax on slack about what we could use in place of "Create items under xxx"

If we used "Open Context Menu for xxx" and changed the do something else button to provide more context for example "Manage xxx"

Let us know what you think

Matt

@nul800sebastiaan
Copy link
Member

Open Context Menu for xxx is good!
I think we'll leave the "Do something else" button for now.

Make sure to remove the TODO that you .. did! ;)

Copy link
Contributor

@emmaburstow emmaburstow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work, Matt. Works as advertised! :)

@emmaburstow emmaburstow merged commit 4153cfe into umbraco:v8/dev Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants