Fix ContentType.Alias matching in PublishedContentExtensions and PublishedElementExtensions #6577
Conversation
…ase-insensitive) match
…nd PublishedElementExtensions to use case insensitive matching
|
Thanks @rbottema - we'll have a look soon! |
Co-Authored-By: Ronald Barendse <[email protected]>
Co-Authored-By: Ronald Barendse <[email protected]>
|
Thanks @rbottema for this excellent update and figuring out the root cause of this bug, well done! Congrats on your first PR merged for Umbraco CMS, great work! 👍 |
|
Thanks also @ronaldbarendse for the feedback, good stuff! |
…ton (#6561) * Improves accessability of the three dot tree options button * Updated list view headers styling to have the link/hand cursor visible only if the header is sortable (and hence clicking has an effect) * Allows members to be ordered by additional system fields (#6575) * Fix ContentType.Alias matching in PublishedContentExtensions an… (#6577) * Fixes an error in #6538 by moving the colon character to the sr-only span * V8: Move misplaced colon in language selector (#6692) * V8: It should be possible to disallow all types at content root (#6580) * Pick macro parameters in an infinite editor like content type properties (#6586) * Reload node children after publishing with descendants * Correct URL decoding of macro partial view names (#6592) * Fix semantics for list views (#6595) * fixes test * fixing tests * Improved menu context
|
Hi there @rbottema, First of all: A big #H5YR for contributing to Umbraco during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 We have had another record breaking amount of PR's in both the CMS, Documentation, and other smaller public repositories. You can read all about the numbers in the Umbraco Hacktoberfest round-up blog post. Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! Receive your swag! 👈 Please follow this link to fill out and submit the form, before December 19th 2019. Following this date we'll be sending out all the swag, which also means that it might not reach your doorstep before February, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
Prerequisites
Fixes #6571.
Description
I went through PublishedContentExtensions and PublishedElementExtensions, fixing all occurrences of Content.Type.Alias matching to what is described in #6571.
The first commit fixes the bug (using Contains instead of Equals) for the ChildrenOfType method (this was the only method with the bug). The second commit changes all matching on ContentType.Alias to use invariant matching.
Locally, all tests (that run) pass. I looked into created a test for the bug case to prevent regression, but I could not quickly figure out how to do so properly.
To test the changes: see reproduction steps in #6571.